Krishnan Anantheswaran

Results 79 comments of Krishnan Anantheswaran

That seems to be an error in parsing your Javascript. Are you sure it is well-formed?

Looks like istanbul is not counting arrow functions as "functions". This should be easy to fix but I'm in he middle of a refactor so I can only get to...

Changed the subject so I can find this issue later :) When you have 2 require statements with different casing, node actually loads the module twice with 2 different names...

Yeah, this is not good. Needs fixing in the instrumenter

I think the problem was something to do with figuring out where the comment is w.r.t the catch clause. Need to take a look.

https://github.com/gotwarlost/istanbul-middleware/blob/master/lib/core.js#L236 Maybe a typo on your part (`ter` not `tor`)?

I've been wanting this functionality for a while. It's a breaking change so please update the major version :)

While I agree with the sentiments above, I have [one crappy native function](https://github.com/splunk/qbec/blob/master/internal/vm/nativefuncs.go#L90) in qbec that depends on `std.thisFile` being available. The user is expected to pass `std.thisFile` as an...

@sbarzowski thanks for the feedback. I didn't assume that deprecate == remove BTW. I'm also fully aware that I'm abusing the API with that native function. I was just using...

Specifically, the conversion is confusing for low hours, for example. If there is a time that is `1h59m` in the future, this shows up as `1 hour from now` instead...