istanbul-middleware icon indicating copy to clipboard operation
istanbul-middleware copied to clipboard

istanbul-middleware.getInstrumentor() no longer works

Open mrvicadai opened this issue 10 years ago • 3 comments

this method is not exposed in handler.js

mrvicadai avatar Aug 25 '14 17:08 mrvicadai

https://github.com/gotwarlost/istanbul-middleware/blob/master/lib/core.js#L236

Maybe a typo on your part (ter not tor)?

gotwarlost avatar Aug 25 '14 17:08 gotwarlost

ohhh sorry about the typo. I mean the real issue is here: at index.js: module.exports = require('./lib/handlers'); so the handlers is exposed, however, in handlers.js: module.exports = { createClientHandler: createClientHandler, createHandler: createHandler, hookLoader: core.hookLoader }; looks like getInstrumenter() is not exposed.

mrvicadai avatar Aug 25 '14 17:08 mrvicadai

this seems legit... see => https://github.com/gotwarlost/istanbul-middleware/issues/47

ORESoftware avatar Jun 01 '17 18:06 ORESoftware