gotjosh

Results 103 comments of gotjosh

> The closest analogy would be the offset modifier we have for selectors and subqueries in PromQL. Maybe the feature should be called "rule query offset" or something like that?...

> Yeah, I understand an am sorry for the pain, but I also believe it's worth to make a user-facing option as clear as possible. Even users who don't need...

@juliusv @roidelapluie I think I have addressed all your concerns now. Let me know if you have any other thoughts. You can look at the last 4 commits if you'd...

@juliusv @roidelapluie @machine424 I have more work I'd like to do around the rules engine so if possible, I'd love to move forward. I'll take your silence as consensus and...

I'm going to proceed with the merge. If there's any additional feedback, please let me know so I can follow up immediately.

I think @bwplotka should have an opinion here, but I'm unsure if he'll ever get to see this. Consolidating usages can only be a good thing -- but I'm unsure...

If autoneg is missing something then I'd say we port over `golang_client`'s implementation here and replace than everywhere.

Those are listed as part of https://github.com/prometheus/docs. I'm transferring this issue to that repository - we would love if you could contribute a PR. Thanks!

This looks good to me, can you please add a test?

@SuperQ George and I went through a quick list of PRs that we can to get merged before we cut this off: https://github.com/prometheus/alertmanager/pull/3827 https://github.com/prometheus/alertmanager/pull/4072 https://github.com/prometheus/alertmanager/pull/4007 https://github.com/prometheus/alertmanager/pull/3560 https://github.com/prometheus/alertmanager/pull/4024 https://github.com/prometheus/alertmanager/pull/3600 We'll attempt...