gotjosh

Results 43 comments of gotjosh

Wow! Thank you so much @m-masataka this looks great. I'm not sure a new API endpoint is the direction we'll take but the front-end changes look 👌 As for your...

Visually, the changes look good and seem like a decent improvement to link individual alerts. However, I'm in no capacity to review the FE changes - perhaps @w0rm you can...

> Should we fail? Or just it should match the empty value? I pondered a bit on that as that was my initial approach, but it felt like allowing it...

> Empty labels are valid in Prometheus and alertmanager. Sorry, I could have been clearer that's what I meant with my comment e.g. you made a mistake while typing and...

> Maybe we could allow foo="" and error on foo=? But this feels a bit inconsistent. I thought that's what I was doing with this PR, but after a close...

After Julien's comment, I took another holistic look and these are my findings: 1. `alertname` as a label is not required by the API (I thought it was - my...

After recently experiencing a panic in one of our largest environments, I realised this is not worth blocking on some sort of theoretical consistency across silences and alerts APIs. The...

I think we can close this PR. It's been superseded by: https://github.com/prometheus/alertmanager/pull/2829, https://github.com/prometheus/alertmanager/pull/2834, https://github.com/prometheus/alertmanager/pull/2835 and https://github.com/prometheus/alertmanager/pull/2894

From the Grafana side, I'm happy to allow you to act on behalf of Grafana Labs (owner of the underlying code in [receivers.go](https://github.com/grafana/grafana/blob/main/pkg/services/ngalert/notifier/receivers.go)) to accomplish this. Let me know if...

I'm not sure I follow the usefulness of this - on your example where you include the grouping, what changed?