vue-realworld-example-app icon indicating copy to clipboard operation
vue-realworld-example-app copied to clipboard

Example of using CASL to create User role for /settings route

Open tecfu opened this issue 7 years ago • 4 comments

Addresses #39.

tecfu avatar Jul 30 '18 19:07 tecfu

There are still conflicts with the master branch. I vote for:

  • deleting package-lock.json in favor of yarn.lock
  • fixing package.json, should not be hard

igeligel avatar Oct 02 '18 21:10 igeligel

There are still conflicts with the master branch. I vote for:

  • deleting package-lock.json in favor of yarn.lock
  • fixing package.json, should not be hard

That commit was flawed. I've made necessary corrections to e49a815

tecfu avatar Oct 03 '18 03:10 tecfu

Why use ctx instead of context as a variable. The whole app uses context and not ctx.

mvsrgc avatar Jan 06 '19 02:01 mvsrgc

Also, in ability.js, you are accessing the state directly while getters are defined for these attributes.

context.state.isAuthenticated and context.state.user instead of the getters.

mvsrgc avatar Jan 06 '19 03:01 mvsrgc