vue-realworld-example-app icon indicating copy to clipboard operation
vue-realworld-example-app copied to clipboard

VTag: Use computed property for router link

Open igeligel opened this issue 5 years ago • 4 comments

<router-link
  :to="{ name: 'home-tag', params: { tag: name } }"
  :class="className"
>

Ideally, { name: 'home-tag', params: { tag: name } } should be a computed property and then used like:

<router-link
  :to="homeLink"
  :class="className"
>

Related resources:

  • https://vuejs.org/v2/guide/computed.html

igeligel avatar Sep 03 '19 19:09 igeligel

I can tackle this if you don't mind.

kylerits avatar Oct 02 '19 17:10 kylerits

PR at #224

kylerits avatar Oct 04 '19 16:10 kylerits

Use computed property for router link #231

andriyfm avatar Oct 06 '19 07:10 andriyfm

@andriyfm this PR got error that name is null We should accept pull request of @kylerits . That PR fix my error

khuongphp avatar Mar 24 '20 03:03 khuongphp