Danny Smith
Danny Smith
FWIW, this actually appears to be correct behaviour. Stata itself uses a different version numbering scheme. Current Stata versions use format 118 for most files, and 119 when there are...
Hi! Thanks for the report. The documentation definitely doesn't align with the behaviour of the argument. My preference would be to update the behaviour but I'll have to see how...
HI @AlejandroDGR, thanks for the bug report. Are you able to share a copy of the file causing the issue so we can investigate?
Perfect, thanks! @evanmiller this is related to #488, but for SPSS files rather than Stata. The fix provided for #488 ignores invalid timestamps rather than throwing an error but only...
Hi! This isn't currently supported in ReadStat - there's an issue floating around in there from a few years ago (WizardMac/Readstat#78). It looks like quite a lot of work on...
Hi @evanmiller! Just wondering if you've had a chance to look at this? Would you prefer that I finalise the full PR before reviewing? As noted I've only implemented the...
Thanks! Good call, shall do 🙂 I'll make that change then add the handler in to the other reader functions and update the PR.
I've renamed the handler to `invalid_string` and added the handler into the row processing code for each of the readers, so should be good to go (i.e. ready for checking...
No worries, I'll add a comment in the header. Given the weirdness it probably warrants a write-up with an example in the "Reading files" section of the README for some...
Hi @evanmiller, just wondering if you had any feedback on the last comment? This is the way I'm leaning: * As well as the header comment, also add a new...