google-cloud-cpp

google-cloud-cpp copied to clipboard

Expose retry policies used by OpenTelemetry Resource Detector

1

We have defaults, but as @coryan points out they should be configurable by the application. Applications not running on GCP will want to disable any retrying. Applications running on GKE...

dbolduc

https://cloud.google.com/cpp/docs/reference/bigtable/latest/classgoogle_1_1cloud_1_1bigtable_1_1ExponentialBackoffPolicy#classgoogle_1_1cloud_1_1bigtable_1_1ExponentialBackoffPolicy_1a77a0d66025cd00fcb33a20d7ce5d562c We have a public constructor using an internal type. We should probably just move it to private. I think that is allowed. Also, the legacy retry classes should be...

dbolduc

This: https://github.com/googleapis/googleapis/blob/119966f0efe4dbe41315de54d8e00ab9c05113a2/google/cloud/aiplatform/v1/deployment_resource_pool_service.proto#L219-L220 generates code that won't compile. We need to access the field to implement the pagination API, but the field is deprecated, so any access generates a warning and...

coryan

Bazel build flakes with "I/O exception during sandboxed execution: Connection reset"

4

* GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/007700b1-80c8-4ee0-8587-62f749948733;tab=detail?project=cloud-cpp-testing-resources * Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/bb6dc521d51e2e27d47827e04a607361e8ee6fd1/fedora-msan-msan/log-007700b1-80c8-4ee0-8587-62f749948733.txt Example: ``` ERROR: /workspace/google/cloud/bigtable/BUILD.bazel:91:9: Compiling google/cloud/bigtable/column_family_test.cc failed: I/O exception during sandboxed execution: Connection reset ``` There may be a Bazel flag or setting to...

coryan

Cleanup Bazel workarounds for gRPC and `apple_rules`

1

gRPC 1.60.x does not compile out of the box with Bazel v7. Bazel v7 requires a newer version of [`apple_rules`](https://github.com/bazelbuild/rules_apple) than what gRPC uses. We can override the version of...

coryan

Use OTel's semantic convention constants when we bump minimum OTel version

3

In the async batch publish, we create a root span using the string instead of the constant, since it does not exist in the oldest deps. https://github.com/googleapis/google-cloud-cpp/pull/13285/files#diff-3e8aefbb8885925f3b6c48b310f1fe9e031aa24315c084fa04cfc13ea5bd86f6R63-R66 Current: ``` opentelemetry::context::Context...

alevenberg

alevenberg

BigQuery V2 Job API: Move the MockBigQueryJobConnection to non internal namespace

1

Move MockBigQueryJobConnection from `bigquery_v2_minimal_internal` to `bigquery_v2_minimal_mocks` namespace when the api is ready to go public. Please see this code review feedback for reference https://reviewable.io/reviews/googleapis/google-cloud-cpp/11037#-NQVNRXKlkAO-JKQLud--r1-23

jsrinnn

WinSvc.h macro mangling methods named CreateService

3

Because of the unfortunate preprocessor definition in WinSvc.h, ``` #ifdef UNICODE #define CreateService CreateServiceW #else #define CreateService CreateServiceA #endif // !UNICODE ``` services that define an rpc named "CreateService" get...

scotthart

Improve collecting and printing diagnostic message from parallel code generation

1

Find a way to capture the protoc errors and send them to GCP_LOG() or maybe even capture them and make them part of each generator thread. Perhaps add a --serialized...

scotthart