gapic-generator-python

gapic-generator-python copied to clipboard

fix: retry all search() request pages

2

GoogleAdsService provides `search()`, which accepts a `Retry()`. Apply the Retry decorator on all request pages, not just the first. Original-Report: https://github.com/googleads/google-ads-python/issues/597 Resolves: https://github.com/googleapis/gapic-generator-python/issues/1242

Kache

This issue was originally reported in python-compute [here](https://github.com/googleapis/python-compute/issues/245). The generated client for python-compute has a [types.py](https://github.com/googleapis/googleapis-gen/blob/master/google/cloud/compute/v1/compute-v1-py/google/cloud/compute_v1/types/compute.py) file which has ~60,000 lines of code and is greater than 2.5 MB. This...

parthea

[This getting started doc](https://github.com/googleapis/gapic-generator-python/blob/main/docs/getting-started/local.rst) references [api-common-protos](https://github.com/googleapis/api-common-protos) which contains outdated proto files. The docs should be updated to use [googleapis](https://github.com/googleapis/googleapis) instead of [api-common-protos](https://github.com/googleapis/api-common-protos). The command should be ``` protoc google/cloud/vision/v1/*.proto \...

parthea

Drop dependency on setuptools

1

The generated code includes a dependency on `setuptools`. It appears that `setuptools` is only needed to get the version of the gapic client via `pkg_resources`. See import statement here https://github.com/googleapis/gapic-generator-python/blob/48c46e3a802ec8d2a69c825b874e73d154a512bf/tests/integration/goldens/asset/google/cloud/asset_v1/services/asset_service/client.py#L20...

parthea

Fixes #1288

parthea

Sphinx warning `Unknown target name: "oneof"` in python-gke-hub , python-compute and python-assured-workloads

2

For python-gke-hub, I added a workaround in owlbot.py [here](https://github.com/googleapis/python-gke-hub/blob/main/owlbot.py#L114) to solve the issue temporarily. See the build log [here](https://source.cloud.google.com/results/invocations/e0239f67-4b37-4af1-b9c8-782f69f07b3d/log) from python-gke-hub . Also see related discussion [here](https://github.com/googleapis/python-gke-hub/pull/94#discussion_r740914920). ``` sphinx.errors.SphinxWarning: /tmpfs/src/github/python-gke-hub/google/cloud/gkehub_v1/configmanagement_v1/types/configmanagement.py:docstring...

parthea

[Grpc call objects](https://grpc.github.io/grpc/python/grpc.html?highlight=channelconnectivity#grpc.StreamUnaryMultiCallable) accept a [grpc.Compression](https://grpc.github.io/grpc/python/grpc.html?highlight=channelconnectivity#grpc.Compression) We should allow passing this parameter to all api calls in the generated library.

acocuzzo

import module alias breaks reference doc

6

Example: https://github.com/googleapis/python-documentai/blob/44ac766870080b84bdb23b7477624cf7570c5a33/google/cloud/documentai_v1beta2/types/document.py#L23 where we have: ``` from google.type import color_pb2 as gt_color ``` The same alias is then used in docstrings such as https://github.com/googleapis/python-documentai/blob/44ac766870080b84bdb23b7477624cf7570c5a33/google/cloud/documentai_v1beta2/types/document.py#L142 in this particular case sphinx seems...

dizcology

ParseErrors for unknown enum responses for GAPICs over REST

2

When a REST endpoint adds a new enum to a response, older versions of the GAPIC library without the enum definition raise parse errors. Details and status in [this document](https://docs.google.com/document/d/1kECNDdhMiDpSIN6pdg7x6wvUcbZUF9-DBH5HxRzQK8w/edit?resourcekey=0-8MU_2OSN8kHwdffi0x3c4g#)....

busunkim96

mypy type error for pager

2

Thanks for stopping by to let us know something could be better! **PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/)...

tmshn