gapic-generator-python

gapic-generator-python copied to clipboard

PR https://github.com/googleapis/gapic-generator-python/pull/1312 added a new parameter `api_audience` however the parameter is not documented in the templates/generated code here: https://github.com/googleapis/gapic-generator-python/blob/main/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/transports/grpc.py.j2#L106

parthea

Gapic Python clients have high load time.

2

I am switching the deprecated [apitools](https://github.com/google/apitools) clients with the new gapic clients and noticed that the gapic clients are much slower to load into memory than their deprecated counterpart. Here...

s4shyam95

The generated client for google/cloud/gkebackup/v1 contains a docstring with a list which is not formatted correctly resulting in the following errors: ``` sphinx.errors.SphinxWarning: /usr/local/google/home/partheniou/git/python-gke-backup/google/cloud/gke_backup_v1/services/backup_for_gke/async_client.py:docstring of google.cloud.gke_backup_v1.services.backup_for_gke.async_client.BackupForGKEAsyncClient.create_backup:44:Block quote ends without a...

parthea

GoogleAdsService doesn't properly apply retries when Retry is passed in

2

Original report: https://github.com/googleads/google-ads-python/issues/597 Directed to this project by @BenRKarl Excerpt: > `GoogleAdsService` provides `search()`, which accepts a [`retry: google.api_core.retry.Retry`](https://github.com/googleapis/python-api-core/blob/c89f55d10df50c222d05ea046e07e05ef7d17725/google/api_core/retry.py#L223). The Retry decorator ends up only getting [applied on the first...

Kache

#### Environment details - OS type and version: Ubuntu 20.04 - Python version: 3.7.13 - pip version: 22.04 - `gapic-generator` version: N/A (bug in already generated libraries) #### Steps to...

elibixby

Resource path helper functions collide when resources in different packages share a name

7

During review of https://github.com/googleapis/python-aiplatform/pull/777, @nicain found that function `test_dataset_path` is defined 3 times in file `test_dataset_path.py` [here](https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/gapic/aiplatform_v1/test_migration_service.py#L1686), [here](https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/gapic/aiplatform_v1/test_migration_service.py#L1710) and [here](https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/gapic/aiplatform_v1/test_migration_service.py#L1734).

parthea

References in square brackets are not referencing to correct UIDs

2

For a lot of client library documentations generated, references in the format `[name][uid]` doesn't seem to point to the correct UID. For example, in Cloud KMS: `[CryptoKeyVersion][google.cloud.kms.v1.CryptoKeyVersion]` should be `google.cloud.kms_v1.types.CryptoKeyVersion`.

dandhlee

Two showcase tests are commented out for handling error details. See [proto-plus-285](https://github.com/googleapis/proto-plus-python/issues/285) issue for details.

software-dov

This PR updates the presubmit checks to also verify the unit tests and coverage for the generated golden files.

parthea

parthea