php-photoslibrary icon indicating copy to clipboard operation
php-photoslibrary copied to clipboard

Fix bug: Samples is saving access token, not refresh token

Open danny-wu opened this issue 5 years ago • 5 comments

There is a bug in the sample code that results in the access token being saved as the refresh token, instead of the refresh token being saved.

See the PR for a fix.

danny-wu avatar Jun 10 '19 09:06 danny-wu

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 10 '19 09:06 googlebot

I signed it!

danny-wu avatar Jun 10 '19 09:06 danny-wu

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Jun 10 '19 09:06 googlebot

@jfschmakeit Not sure if you're the maintainer, if so this PR is for you.

Took me hours and hours to debug why I was getting the "token expired" error after 1 hour, turns out the sample code has a bug in it. Shows you how hard OAuth is, lol.

danny-wu avatar Jun 10 '19 09:06 danny-wu

OAuth

how did you fix it ?

shorts7wound avatar Feb 20 '21 22:02 shorts7wound