comprehensive-rust
comprehensive-rust copied to clipboard
google
ja: Translate chapter 52 (Async Basics)
Hi, this is ja translation (#652 ) of chapter 52 (Async Basics):
52. Async Basics
52.1. async/await
52.2. Futures
52.3. Runtimes
52.4. Tasks
52.5. Async Channels
I'm new to this project and technical translations. Any suggestions and feedback are appreciated :) Have a great week.
Hi, I'll use the branch name japanese-translate-ch-YYYfrom the next PR. I tried to look at related issues/PRs but if there're some other Japanese translation specific rules, I'm happy to learn about them :)
https://github.com/google/comprehensive-rust/issues/652#issuecomment-1567731331
Hi @chikoski thank you for your valuable feedback! I've reflected suggested changes, and commited and could you review the changes?
Hi @kantasv, can you "resolve" the discussions above where you've already incorporated the feedback. That might make it easier for @chikoski to review.
There also seems to be a conflict. It's just a tiny one because both the author and timestamp was updated:
I suggest not updating those fields since they're a left-over from an era where people didn't have version control system like we do today :smile:
Hi, @mgeisler thanks for the follow-up :-) I've resolved disucussions for the incooporated changes. Plus I've adjusted translator header infor to reduce future conflict resolution.
Hi, @mgeisler thanks for the follow-up :-) I've resolved disucussions for the incooporated changes. Plus I've adjusted translator header infor to reduce future conflict resolution.
Excellent! I hope we can have @chikoski look it over soon.
Dear @chikoski and @keiichiw, please take a look at this so we can merge the PR. Thanks!
Sorry for the slow response. I left several comments. Once they're addressed, I think we can merge this PR
Hi, @keiichiw -san. I've incorporated your suggestions and submit changes. Could you run the CI and merge it if it looks good. Thank you :)