comprehensive-rust
comprehensive-rust copied to clipboard
google
bn: Fixed some translations and added more
Hi @raselmandol, a very small comment: could you prefix the PRs (and issues) with bn:. That just makes it a little easier to see what the PR is about. Later, the PR title will go into the history in the repository and then it is also useful to have a consistent prefix.
@mgeisler, I apologize for not including the 'bn: ' prefix in my previous Pull Request. I will surely do that from next time.
I don't think it's practically possible to review the entire thing at one go. I appreciate your efforts @raselmandol, thank you! If you can send smaller changes, it would be easier for us to review.
I forget if I mentioned it already, but you can find the rendered course at the bottom of the test result page.
I would suggest skimming through it and if it nothing is too broken, then let's merge this as a start. The course will not be published just yet, so we can iterate on it as much as you all like.
Even after publishing it, we can control if we want to link to the course. As an example, I've written a very incomplete Danish translation which can be found here: https://google.github.io/comprehensive-rust/da/. But it's not yet linked from Translations or from the drop-down menu in the top right. So we have that flexibility as well :smile:
@mirwasi , I apologize for the Bangla-English mixing and other translations that were not correct. I have already solved the mentioned problems but I am not creating a pull request now because I am rechecking all the translations. Also, I will try not to add more translations at a time and I am discussing the translation with some Bengali forums so that it can be more appropriate. After rechecking then I will again create a pull request.
Please don't apologise, @raselmandol! 😄 Thank you so much for all your efforts! As you are already working on the suggedtions, I'm approving this one.
Thanks for the help with reviewing, @mirwasi and @sudiptachatterjee! And a huge thank to @raselmandol for creating the translation! :smile:
@mirwasi, please merge the PR when you like.