comprehensive-rust
comprehensive-rust copied to clipboard
Add Korean translation
about #262 This is a Korean translation draft file(ko.po) that reflects the commitment of f3446a91(25 jan 2023)
I'm sorry that it seems to be a similar PR(#276) duplication, but there is a difference in the scope of the work, so I'm uploading the PR. I added it by referring to the @jiyongp comment in #276. Thank you. However, as a developer in Korea, there were some opinions, so I couldn't reflect them all. Please let me know if anyone have any additional comments on the following. Or anything else.
- Copying and Cloning: I don't think we need to use the original language as it is, as it can be divided into 복사 and 복제 rather than copying the word itself.
- Shared and Unique Borrows: Translating Unique into '단독' would confuse with single.
- Designing a Library: It's an actual book library system, so I kept it as a '도서관'
- Niche Optimization: '소소한' doesn't convey the meaning of niche, and in Korea, and Korean developers' blogs use it as 'niche Optimization'. so I'm maintaining it for now.
- Paths: I don't think it's a separate type of Paths, it's an absolute/relative path, so I kept it as a path. It will be applied after checking again.
- Trait: I understood it as a big characteristic of Rust, so I got a tuning fork in the original language. The word "특성" comes in general meanings like attributes and properties.
- DEFERENCING Raw Pointers: I agree, but I'm writing it in '역참조(따라가기)' because I think it's right to explain it in terms that are understandable to existing developers.
- Mutable Static Variables: '가변 정적 변수' / '정적 가변 변수' all have the same meaning, and I thought write '가변' in sentence form, I think '정적' should be the same. so I kept it.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
- Copying and Cloning: I don't think we need to use the original language as it is, as it can be divided into 복사 and 복제 rather than copying the word itself.
Ack.
- Shared and Unique Borrows: Translating Unique into '단독' would confuse with single.
- Designing a Library: It's an actual book library system, so I kept it as a '도서관'
Oh I missed that. Thanks for correcting.
- Niche Optimization: '소소한' doesn't convey the meaning of niche, and in Korea, and Korean developers' blogs use it as 'niche Optimization'. so I'm maintaining it for now.
Ok.
- Paths: I don't think it's a separate type of Paths, it's an absolute/relative path, so I kept it as a path. It will be applied after checking again.
You are right.
- Trait: I understood it as a big characteristic of Rust, so I got a tuning fork in the original language. The word "특성" comes in general meanings like attributes and properties.
I am fine with 트레이트(Trait). Note that we should drop s from Traits.
- DEFERENCING Raw Pointers: I agree, but I'm writing it in '역참조(따라가기)' because I think it's right to explain it in terms that are understandable to existing developers.
Ack. We can't fix the existing habit. :(
- Mutable Static Variables: '가변 정적 변수' / '정적 가변 변수' all have the same meaning, and I thought write '가변' in sentence form, I think '정적' should be the same. so I kept it.
I'd like to merge this series sooner than later. So please tell me when you are ready. There might be more places to fix (I haven't read all the translations yet), but I think those could be fixed later.
Yes, there are quite a few ambiguous meanings (because it's only been a few weeks since I studied Rust), but the PR is now up-to-date with the latest version of the upstream. I think it would be good to continue to get reviews from many people and improve it.
I'd like to merge this series sooner than later. So please tell me when you are ready. There might be more places to fix (I haven't read all the translations yet), but I think those could be fixed later.
@mgeisler do you agree?
I'm happy to merge this! Thanks so much @keispace for the work and thank you @jiyongp for proof-reading it!'
We can merge this now, and then we can enable the publication of the translation on Monday (by editing publish.yml
). The idea is that we can de-couple the development of a translation (which can take a long time) from the publication of the translation.
@keispace, can you add a line with
- ko
to the build.yml
file?
Based on @jiyongp's comments, I think you should also go ahead and update publish.yml
so that we can publish this right away next week :tada:
@keispace, can you add a line with
- ko
to the
build.yml
file?Based on @jiyongp's comments, I think you should also go ahead and update
publish.yml
so that we can publish this right away next week 🎉
@mgeisler
I'm not familiar with the Git workflow and I'm careful to modify it other than the translation file, so I just modified the po file for now. I've added the part you mentioned.
And I want to add it to the 'LANGUAGES' in the publish.yml
file, but I left it for now because there was an error in writing the list.
@keispace, please fix the errors from Test/translations (ko)
. There are multiple places where the newline character is missing.
Or you may follow the instructions at https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork (which is basically selecting the checkbox "Allow edits from maintainers") so that I can make the fix by myself.
I've merged #300 which is an amendment of this PR. Let's close this here. Thanks @keispace for your contribution.