comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Initial Korean commit

Open joosangkim opened this issue 2 years ago • 6 comments

Initial commit Korean translation discussed on https://github.com/google/comprehensive-rust/issues/262

joosangkim avatar Jan 25 '23 06:01 joosangkim

Hi @joosangkim, thanks a lot! Do you work with @keispace on this?

mgeisler avatar Jan 25 '23 16:01 mgeisler

Hi again, I just looked at the build step which runs msgfmt on the translation and it says

$ msgfmt --statistics -o /dev/null po/ko.po
30 translated messages, 1723 untranslated messages

In the ko.zip file from https://github.com/google/comprehensive-rust/pull/130#issuecomment-1378577067, we have 461 translated strings (and 333 "fuzzy" strings which need someone to look at them). This file is based on @keispace's work.

If you didn't see the file, I would love for you to combine the two ko.po files. You can use msgcat for this.

mgeisler avatar Jan 25 '23 17:01 mgeisler

Hi @keispace . Thanks for translating https://google.github.io/comprehensive-rust/ into Korean first. Unfortunately, you and I have both worked on the same spot. What I've done on this PR is merging your translations and fixing templating issue(msgfmt) following @mgeisler 's comments above.

joosangkim avatar Jan 26 '23 02:01 joosangkim

Hi @keispace . Thanks for translating https://google.github.io/comprehensive-rust/ into Korean first. Unfortunately, you and I have both worked on the same spot. What I've done on this PR is merging your translations and fixing templating issue(msgfmt) following @mgeisler 's comments above.

@joosangkim Hello, I am currently working on google/main modifications as of January 25th after the full translation draft has been completed. Not yet done but working if needed (fuzzy part needs to be worked) I'll share the branch. You can refer to the ko.po file.

@mgeisler My translation work will be completed around tomorrow, but I'm not sure if it's right for several Korean translation PRs to go up.


안녕하세요. 관심있는 분이 또 계시니 반갑네요. 저는 현재 전체 번역 초안이 완료 되고 1월 25일 기준으로 google/main 수정사항을 작업 중입니다. 아직 완료는 되지 않았지만 필요하시면 작업중인(fuzzy 부분 및 4일차 키노트 미완료) 저장소 공유드리겠습니다. ko.po 파일 참고하시면 될거 같습니다.

제 번역 작업은 내일 쯤 완료 될텐데 한국어 번역 PR이 여러개 올라가는게 맞는지 모르겠네요

keispace avatar Jan 26 '23 09:01 keispace

안녕하세요. 관심있는 분이 또 계시니 반갑네요. 저는 현재 전체 번역 초안이 완료 되고 1월 25일 기준으로 google/main 수정사항을 작업 중입니다. 아직 완료는 되지 않았지만 필요하시면 작업중인(fuzzy 부분 및 4일차 키노트 미완료) 저장소 공유드리겠습니다. ko.po 파일 참고하시면 될거 같습니다.

제 번역 작업은 내일 쯤 완료 될텐데 한국어 번역 PR이 여러개 올라가는게 맞는지 모르겠네요

I am a Korean software engineer working for Android @ Google. mgeisler invited me to review this translation. By the way, since we are chasing a moving target, I think we better submit this commit as is and fix the remaining issues separately as follow-ups.

jiyongp avatar Jan 26 '23 09:01 jiyongp

@mgeisler My translation work will be completed around tomorrow, but I'm not sure if it's right for several Korean translation PRs to go up.

Hi @keispace, I agree — it's cool to see that many people are interested :smile: However, we should focus on getting your first draft committed! Thank you again for the huge work you've done here.

@joosangkim, thank you also for your work. I think we should pause this PR until we have the changes from @keispace. I'm sorry about the duplication, I hope we caught it before you invested too much time here. Perhaps you can help @keispace with keeping the translation up to date as we make small changes to the course going forward?

mgeisler avatar Jan 26 '23 17:01 mgeisler

Thanks @keispace for opening #290! I believe we can close this PR now and then concentrate on fixing any remaining small issues in the Korean translation after #290 is merged.

mgeisler avatar Jan 27 '23 17:01 mgeisler