comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

Cannot search for "`From` and `Into`"

Open fw-immunant opened this issue 1 year ago • 4 comments

I think this is because the search functionality in elasticlunr ignores these in queries as "stop words". This seems like it might need fixing in upstream mdbook, but I'm not sure.

We may also want to verify that searching in non-English languages works (see https://github.com/rust-lang/mdBook/issues/1081).

fw-immunant avatar May 09 '24 13:05 fw-immunant

Yeah, this is a great point and something we should look into!

mgeisler avatar Sep 07 '24 11:09 mgeisler

Let me add give this the "good first issue" label so it shows up in https://github.com/google/comprehensive-rust/contribute.

mgeisler avatar Sep 07 '24 11:09 mgeisler

I looked into this some and because it seems to be an issue with the js implementation of the search index, I don't know if a new contributor would have a good time fixing it. I gave up after spending a couple hours.

fw-immunant avatar Sep 12 '24 21:09 fw-immunant

It sounds like you do know a new contrinbutor wouldn't have a good time :)

djmitche avatar Sep 13 '24 12:09 djmitche