comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

es: Course length mistake

Open salvamunoz opened this issue 1 year ago • 3 comments

Edit course length from 3 days to 4 which is actually the total length

salvamunoz avatar May 01 '24 10:05 salvamunoz

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 01 '24 10:05 google-cla[bot]

The original english text does not mention the length. I would recommend to just rearrange the translation to match the same.

Also, you need to sign the CLA as mentioned above.

deavid avatar May 01 '24 12:05 deavid

@salvamunoz, can you take out the mentioning of days like @deavid suggests? Then we can merge this!

mgeisler avatar May 28 '24 09:05 mgeisler

Yes, that's correct Spanish

On Wed, 21 Aug 2024, 07:29 Martin Geisler, @.***> wrote:

@.**** commented on this pull request.

In po/es.po https://github.com/google/comprehensive-rust/pull/2043#discussion_r1724468459 :

@@ -1217,7 +1217,7 @@ msgid "" "course covers the full spectrum of Rust, from basic syntax to advanced " "topics like generics and error handling." msgstr "" -"Este es un curso de Rust de tres días que ha desarrollado el equipo de " +"Este es un curso de Rust de cuatro días que ha desarrollado el equipo de "

@salvamunoz https://github.com/salvamunoz and @deavid https://github.com/deavid, is this correct Spanish? ⬇️ Suggested change

-"Este es un curso de Rust de cuatro días que ha desarrollado el equipo de " +"Este es un curso de Rust que ha desarrollado el equipo de "

— Reply to this email directly, view it on GitHub https://github.com/google/comprehensive-rust/pull/2043#pullrequestreview-2249835342, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFJRLRRPIAZE3QTYBX5MDZSQXVFAVCNFSM6AAAAABHBYEUCCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBZHAZTKMZUGI . You are receiving this because you were mentioned.Message ID: @.***>

deavid avatar Aug 23 '24 16:08 deavid

Yes, that's correct Spanish

Thanks a lot! :tada:

mgeisler avatar Aug 27 '24 15:08 mgeisler