comprehensive-rust icon indicating copy to clipboard operation
comprehensive-rust copied to clipboard

fa : [1/12] Persian translations

Open alix1383 opened this issue 9 months ago • 6 comments

#671

  • [x] index

  • [x] cargo

  • [x] running-the-course

    Day 1: Morning

    • [x] Welcome
    • [x] Pattern Matching
    • [x] Methods and Traits

    Day 1: Afternoon

    • [x] Welcome
    • [x] Tuples and Arrays
    • [x] References
    • [x] User-Defined Types

alix1383 avatar Apr 30 '24 10:04 alix1383

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 30 '24 10:04 google-cla[bot]

Please see Formatting for how to install the tools you need to format the .po file. You simply need to run dprint fmt after installing them.

Also note that this PR refreshes the translation while also improving it. This is discouraged because it creates a very large diff, which is hard to review.

The best way of looking at the diff is to use gh with bat:

gh pr diff 2038 | bat -l patch

mgeisler avatar May 03 '24 13:05 mgeisler

@mgeisler no one review changes...

alix1383 avatar May 08 '24 17:05 alix1383

hi @alix1383. I don't understand the changes you made. It is better to use ‍‍dprint fmt before git commit and push as mentioned above and then push here.

DannyRavi avatar May 09 '24 08:05 DannyRavi

hi @alix1383. I don't understand the changes you made. It is better to use ‍‍dprint fmt before git commit and push as mentioned above and then push here.

I run dprint fmt before committing but nothing changes also gettext already installed

alix1383 avatar May 09 '24 11:05 alix1383

I run dprint fmt before committing but nothing changes also gettext already installed

I think the formatting is fine now — the check passes on GitHub.

@DannyRavi, maybe the confusion is that this PR has a ton of changes because it also includes new English strings.

mgeisler avatar May 15 '24 11:05 mgeisler

Sorry I was not active in the post months. I'm back now and will review any changes related to Persian translations.

@alix1383 If you apply these updated strings I believe this is good to go as an start.

mehrad77 avatar Jun 07 '24 14:06 mehrad77

I mage a merge request (!2128) regarding updating new English strings so we can merge that independently to clear up this MR diffs.

mehrad77 avatar Jun 07 '24 14:06 mehrad77

@DannyRavi @mehrad77 ممنون از اینکه وقت گذاشتید و تغییرات رو برسی کردید.

درحال‌حاضر من سرم شلوغه(کنکور) اما در اولین فرصت تغییرات رو اعمال میکنم

alix1383 avatar Jun 21 '24 05:06 alix1383

@alix1383 I wish you the best and I hope you get a good result in the entrance exam.

DannyRavi avatar Jul 20 '24 08:07 DannyRavi

Hey folks, I don't know if it's applicable here, but I recently ran into having to hand-merge some out-of-date .po files: https://github.com/google/comprehensive-rust/pull/1948#issuecomment-2301415834. The recipe there basically treats each file as a large (msgid, msgstr) map and takes the union of the two files. That "trick" might come in handy here or in other PRs.

mgeisler avatar Aug 28 '24 07:08 mgeisler