Aleksei Khoroshilov
Aleksei Khoroshilov
@sangwoo108 please don't force push when a code-review is already in progress. I have no idea what has changed since last time :) IMO it's okay to force push when...
### Some info after experiments on `mac-imac3-ky`. 1. The `lld` crash is pretty rare (around 1 in ~100 links) and only happens in `lld` `Release/RelWithDebInfo` configurations. 2. Rebuilding `lld` with...
The PR with a workaround is ready to be merged, but I'd like to see another failure on `nightly` before merging in case the issue has been fixed in upstream...
yes, let's wrap up. If it will reappear, we'll return to the workaround.
> @goodov do we know how this got fixed? no. I tried to look into the build history to figure out when the crashes stopped to maybe map to a...
This test also fails with enabled dchecks. I'm going to disable it until the proper fix is applied. Most likely the issue is: we need to await for download steps...
> @goodov is this something you can take a look at and pick up? Otherwise, let's close this one and we'll keep in the disabled list for now. Someone from...
Can confirm. `toBinary` and `toJson` doesn't output default values for `required` fields when we use `proto2`. Is this a bug or intended behavior? This should be solvable somehow. One approach...
The info on [partial support for proto2](https://github.com/timostamm/protobuf-ts/blob/main/MANUAL.md#proto2-support) is a bit outdated. The library is able to serialize and deserialize such fields without issues, there's no any `bool` fallback. From my...
I'm a little concerned about the whole "scan this huge dir on startup" process. In Chromium Reclient is auto started/stopped during each `autoninja` invocation. This is different compared to how...