brave-browser icon indicating copy to clipboard operation
brave-browser copied to clipboard

Published 20 hours ago • verified publisher icon brave

Test failure: AdBlockServiceTest.SubscribeToCustomSubscription

Open brave-builds opened this issue 1 year ago • 8 comments

Greetings human!

Bad news. AdBlockServiceTest.SubscribeToCustomSubscription failed on windows x64 nightly master.

Stack trace 
[ RUN      ] AdBlockServiceTest.SubscribeToCustomSubscription
[8184:11384:1008/212451.562:WARNING:chrome_main_delegate.cc(613)] This is Chrome version 118.1.61.8 (not a warning)
[8184:11384:1008/212451.573:WARNING:policy_logger.cc(148)] :components\enterprise\browser\controller\chrome_browser_cloud_management_controller.cc(88) Could not create policy manager as CBCM is not enabled.
[8184:11384:1008/212451.677:ERROR:policy_logger.cc(154)] :components\enterprise\browser\controller\chrome_browser_cloud_management_controller.cc(163) Cloud management controller initialization aborted as CBCM is not enabled.
[8184:11384:1008/212451.874:WARNING:external_provider_impl.cc(513)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
[8184:11384:1008/212454.948:WARNING:brave_stats_updater_params.cc(129)] Couldn't find the time of first run. This should only happen when running tests, but never in production code.
[8184:11384:1008/212457.172:WARNING:controller_impl.cc(1188)] Background download complete, client: 255, completion type: 0, file size:97
[8184:11384:1008/212457.213:WARNING:controller_impl.cc(1188)] Background download complete, client: 255, completion type: 0, file size:97
..\..\brave\browser\brave_shields\ad_block_service_browsertest.cc(853): error: Expected equality of these values:
  true
  EvalJs(contents, base::StringPrintf("setExpectations(0, 0, 1, 1);" "xhr('%s')", resource_url.spec().c_str()))
    Which is: false
Stack trace:
	AdBlockServiceTest_SubscribeToCustomSubscription_Test::RunTestOnMainThread [0x00007FF621D2F4E3+26833] (C:\jenkins\x64-nightly\src\brave\browser\brave_shields\ad_block_service_browsertest.cc:850)
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF63629B2B5+2449] (C:\jenkins\x64-nightly\src\content\public\test\browser_test_base.cc:934)
	base::internal::Invoker<base::internal::BindState<void (content::BrowserTestBase::*)(),base::internal::UnretainedWrapper<content::BrowserTestBase,base::unretained_traits::MayNotDangle,0> >,void ()>::Run [0x00007FF63629FFCC+340] (C:\jenkins\x64-nightly\src\base\functional\bind_internal.h:919)
	content::BrowserMainLoop::InterceptMainMessageLoopRun [0x00007FF62B0BB5C6+424] (C:\jenkins\x64-nightly\src\content\browser\browser_main_loop.cc:1043)
	content::BrowserMainLoop::RunMainMessageLoop [0x00007FF62B0BB7B4+222] (C:\jenkins\x64-nightly\src\content\browser\browser_main_loop.cc:1055)
	content::BrowserMainRunnerImpl::Run [0x00007FF62B0C2906+42] (C:\jenkins\x64-nightly\src\content\browser\browser_main_runner_impl.cc:160)
	content::BrowserMain [0x00007FF62B0B2D85+545] (C:\jenkins\x64-nightly\src\content\browser\browser_main.cc:34)
	content::RunBrowserProcessMain [0x00007FF62FA7C63D+673] (C:\jenkins\x64-nightly\src\content\app\content_main_runner_impl.cc:704)
	content::ContentMainRunnerImpl::RunBrowser [0x00007FF62FA8052A+1212] (C:\jenkins\x64-nightly\src\content\app\content_main_runner_impl.cc:1288)
	content::ContentMainRunnerImpl::Run [0x00007FF62FA7FC14+2742] (C:\jenkins\x64-nightly\src\content\app\content_main_runner_impl.cc:1138)
	content::RunContentProcess [0x00007FF62FA7A471+2567] (C:\jenkins\x64-nightly\src\content\app\content_main.cc:326)
	content::ContentMain [0x00007FF62FA7B0FE+604] (C:\jenkins\x64-nightly\src\content\app\content_main.cc:343)
	content::BrowserTestBase::SetUp [0x00007FF636298BE7+6043] (C:\jenkins\x64-nightly\src\content\public\test\browser_test_base.cc:602)
	InProcessBrowserTest::SetUp [0x00007FF6319F7B48+1172] (C:\jenkins\x64-nightly\src\chrome\test\base\in_process_browser_test.cc:593)
[8184:11384:1008/212459.755:WARNING:controller_impl.cc(1188)] Background download complete, client: 255, completion type: 0, file size:97
[8184:11384:1008/212459.948:WARNING:controller_impl.cc(1188)] Background download complete, client: 255, completion type: 1, file size:0
[8184:11384:1008/212500.100:WARNING:task_environment.cc(942)] ParallelExecutionFence is ineffective when ThreadPoolInstance is not managed by a TaskEnvironment.
Test fixtures should use a TaskEnvironment member or statically invoke TaskEnvironment::CreateThreadPool() + ThreadPoolInstance::Get()->StartWithDefaultParams() when the former is not possible.
[8184:11384:1008/212500.105:WARNING:task_environment.cc(942)] ParallelExecutionFence is ineffective when ThreadPoolInstance is not managed by a TaskEnvironment.
Test fixtures should use a TaskEnvironment member or statically invoke TaskEnvironment::CreateThreadPool() + ThreadPoolInstance::Get()->StartWithDefaultParams() when the former is not possible.
[  FAILED  ] AdBlockServiceTest.SubscribeToCustomSubscription, where TypeParam =  and GetParam() =  (8552 ms)

[  FAILED  ] AdBlockServiceTest.SubscribeToCustomSubscription

brave-builds avatar Oct 08 '23 23:10 brave-builds

AdBlockServiceTest.SubscribeToCustomSubscription failed on macos arm64 nightly v1.61.12.

Stack trace 
[ RUN      ] AdBlockServiceTest.SubscribeToCustomSubscription
[76552:259:1009/203318.901865:WARNING:chrome_main_delegate.cc(613)] This is Chrome version 118.1.61.12 (not a warning)
[76552:259:1009/203318.917026:WARNING:policy_logger.cc(148)] :components/enterprise/browser/controller/chrome_browser_cloud_management_controller.cc(88) Could not create policy manager as CBCM is not enabled.
[76552:259:1009/203318.941231:ERROR:policy_logger.cc(154)] :components/enterprise/browser/controller/chrome_browser_cloud_management_controller.cc(163) Cloud management controller initialization aborted as CBCM is not enabled.
[76552:259:1009/203318.955272:WARNING:external_provider_impl.cc(513)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
[76552:72963:1009/203318.960220:INFO:brave_referrals_service.cc(143)] Could not get promo code from /Users/jenkins/jenkins/workspace/brave-browser-build-macos-arm64-nightly/src/out/Release_arm64. The extended attribute com.brave.refcode was not found.
[76552:35331:1009/203321.299324:WARNING:quarantine_mac.mm(67)] MDItemCreate failed for path /private/var/folders/sv/qwvr6d4j5tz7rv6w74mvzzvc0000gp/T/scoped_dirz3UdSO/user_data/Default/Download Service/Files/097f3718-2dfa-4d47-a8a9-c3c54c4f56a2
[76552:41987:1009/203321.299649:WARNING:quarantine_mac.mm(67)] MDItemCreate failed for path /private/var/folders/sv/qwvr6d4j5tz7rv6w74mvzzvc0000gp/T/scoped_dirz3UdSO/user_data/Default/Download Service/Files/58d487dc-d62a-44bc-8d0f-dcb6bfda6dcc
[76552:259:1009/203321.299796:WARNING:controller_impl.cc(1188)] Background download complete, client: 255, completion type: 0, file size:97
[76552:259:1009/203321.300130:WARNING:controller_impl.cc(1188)] Background download complete, client: 255, completion type: 0, file size:97
../../brave/browser/brave_shields/ad_block_service_browsertest.cc:878: Failure
Expected equality of these values:
  true
  EvalJs(contents, base::StringPrintf("setExpectations(0, 0, 1, 1);" "xhr('%s')", resource_url.spec().c_str()))
    Which is: false
Stack trace:
0   brave_browser_tests                 0x00000001007624d0 speedreader_new + 188352
1   brave_browser_tests                 0x00000001098d64b8 curve25519_dalek::scalar::Scalar::to_bytes::hb936abff285f4961 + 6295348
2   brave_browser_tests                 0x0000000102b62ba4 tracing_core::span::Attributes::is_root::h3a850983c953e6e3 + 6589048
3   brave_browser_tests                 0x0000000102b64528 tracing_core::span::Attributes::is_root::h3a850983c953e6e3 + 6595580
4   brave_browser_tests                 0x0000000102b604e8 tracing_core::span::Attributes::is_root::h3a850983c953e6e3 + 6579132
5   brave_browser_tests                 0x0000000103bd3200 tracing_subscriber::registry::sharded::CloseGuard::is_closing::hd2ae1a04d41405d3 + 16312280
6   brave_browser_tests                 0x0000000103bd442c tracing_subscriber::registry::sharded::CloseGuard::is_closing::hd2ae1a04d41405d3 + 16316932
7   brave_browser_tests                 0x0000000103bd40c4 tracing_subscriber::registry::sharded::CloseGuard::is_closing::hd2ae1a04d41405d3 + 16316060
8   brave_browser_tests                 0x0000000103bd2934 tracing_subscriber::registry::sharded::CloseGuard::is_closing::hd2ae1a04d41405d3 + 16310028
9   brave_browser_tests                 0x0000000103bd2b38 tracing_subscriber::registry::sharded::CloseGuard::is_closing::hd2ae1a04d41405d3 + 16310544
10  brave_browser_tests                 0x00000001098d5998 curve25519_dalek::scalar::Scalar::to_bytes::hb936abff285f4961 + 6292500
[76552:35331:1009/203321.408330:WARNING:quarantine_mac.mm(67)] MDItemCreate failed for path /private/var/folders/sv/qwvr6d4j5tz7rv6w74mvzzvc0000gp/T/scoped_dirz3UdSO/user_data/Default/Download Service/Files/08a700c7-2330-4a4c-8de1-51bad558e5c6
[76552:259:1009/203321.408469:WARNING:controller_impl.cc(1188)] Background download complete, client: 255, completion type: 0, file size:97
[76552:259:1009/203321.520604:WARNING:task_environment.cc(942)] ParallelExecutionFence is ineffective when ThreadPoolInstance is not managed by a TaskEnvironment.
Test fixtures should use a TaskEnvironment member or statically invoke TaskEnvironment::CreateThreadPool() + ThreadPoolInstance::Get()->StartWithDefaultParams() when the former is not possible.
[76552:259:1009/203321.520840:WARNING:task_environment.cc(942)] ParallelExecutionFence is ineffective when ThreadPoolInstance is not managed by a TaskEnvironment.
Test fixtures should use a TaskEnvironment member or statically invoke TaskEnvironment::CreateThreadPool() + ThreadPoolInstance::Get()->StartWithDefaultParams() when the former is not possible.
[  FAILED  ] AdBlockServiceTest.SubscribeToCustomSubscription, where TypeParam =  and GetParam() =  (2627 ms)

[  FAILED  ] AdBlockServiceTest.SubscribeToCustomSubscription

brave-builds avatar Oct 10 '23 04:10 brave-builds

cc: @antonok-edm

rebron avatar Oct 23 '23 14:10 rebron

AdBlockServiceTest.SubscribeToCustomSubscription failed on windows x64 nightly v1.62.49.

Stack trace 
[ RUN      ] AdBlockServiceTest.SubscribeToCustomSubscription
[6944:8080:1113/172415.135:WARNING:chrome_main_delegate.cc(660)] This is Chrome version 119.1.62.49 (not a warning)
[6944:8080:1113/172415.138:WARNING:policy_logger.cc(151)] :components\enterprise\browser\controller\chrome_browser_cloud_management_controller.cc(88) Could not create policy manager as CBCM is not enabled.
[6944:8080:1113/172415.168:ERROR:policy_logger.cc(157)] :components\enterprise\browser\controller\chrome_browser_cloud_management_controller.cc(163) Cloud management controller initialization aborted as CBCM is not enabled.
[6944:8080:1113/172415.186:WARNING:external_provider_impl.cc(513)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
tracing_subscriber - init success
[6944:8080:1113/172415.296:INFO:mod.rs(74)]   skus::sdk: skus sdk initialized, environment: production, version: "unknown"
    at ../../brave/components/skus/browser/rs/lib/src\sdk\mod.rs:74
[6944:8080:1113/172415.296:VERBOSE1:kv.rs(126)]   skus::storage::kv: got orders, orders: None
    at ../../brave/components/skus/browser/rs/lib/src\storage\kv.rs:126
    in skus::storage::kv::get_orders with self=NativeClient
    in skus::sdk::credentials::matching_credential_summary with self=SDK domain="leo.brave.com"
[6944:8080:1113/172418.216:WARNING:brave_stats_updater_params.cc(129)] Couldn't find the time of first run. This should only happen when running tests, but never in production code.
[6944:8080:1113/172419.511:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 0, file size:97
[6944:8080:1113/172419.522:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 0, file size:97
..\..\brave\browser\brave_shields\ad_block_service_browsertest.cc(908): error: Expected equality of these values:
  true
  EvalJs(contents, base::StringPrintf("setExpectations(0, 0, 1, 1);" "xhr('%s')", resource_url.spec().c_str()))
    Which is: false
Stack trace:
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF6F817CC58+872] (C:\jenkins\x64-nightly\src\content\public\test\browser_test_base.cc:937)
	content::BrowserMainLoop::RunMainMessageLoop [0x00007FF6F6A08336+246] (C:\jenkins\x64-nightly\src\content\browser\browser_main_loop.cc:1078)
	content::BrowserMainRunnerImpl::Run [0x00007FF6F6A0A291+17] (C:\jenkins\x64-nightly\src\content\browser\browser_main_runner_impl.cc:160)
	content::BrowserMain [0x00007FF6F6A0531B+155] (C:\jenkins\x64-nightly\src\content\browser\browser_main.cc:34)
	content::RunBrowserProcessMain [0x00007FF6F73C42D3+211] (C:\jenkins\x64-nightly\src\content\app\content_main_runner_impl.cc:707)
	content::ContentMainRunnerImpl::RunBrowser [0x00007FF6F73C5811+1121] (C:\jenkins\x64-nightly\src\content\app\content_main_runner_impl.cc:1298)
	content::ContentMainRunnerImpl::Run [0x00007FF6F73C52DA+778] (C:\jenkins\x64-nightly\src\content\app\content_main_runner_impl.cc:1142)
	content::RunContentProcess [0x00007FF6F73C3BA7+1159] (C:\jenkins\x64-nightly\src\content\app\content_main.cc:334)
	content::ContentMain [0x00007FF6F73C3D1D+125] (C:\jenkins\x64-nightly\src\content\app\content_main.cc:347)
	content::BrowserTestBase::SetUp [0x00007FF6F817BFFC+2428] (C:\jenkins\x64-nightly\src\content\public\test\browser_test_base.cc:604)
	InProcessBrowserTest::SetUp [0x00007FF6F77DC3F9+649] (C:\jenkins\x64-nightly\src\chrome\test\base\in_process_browser_test.cc:595)
[6944:8080:1113/172422.353:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 0, file size:97
[6944:8080:1113/172422.374:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 1, file size:0
[  FAILED  ] AdBlockServiceTest.SubscribeToCustomSubscription, where TypeParam =  and GetParam() =  (7270 ms)

[  FAILED  ] AdBlockServiceTest.SubscribeToCustomSubscription

brave-builds avatar Nov 13 '23 18:11 brave-builds

AdBlockServiceTest.SubscribeToCustomSubscription failed on windows x64 nightly v1.62.59.

Stack trace 
[ RUN      ] AdBlockServiceTest.SubscribeToCustomSubscription
[28220:32052:1116/182248.281:WARNING:chrome_main_delegate.cc(660)] This is Chrome version 119.1.62.59 (not a warning)
[28220:32052:1116/182248.284:WARNING:policy_logger.cc(151)] :components\enterprise\browser\controller\chrome_browser_cloud_management_controller.cc(88) Could not create policy manager as CBCM is not enabled.
[28220:32052:1116/182248.312:ERROR:policy_logger.cc(157)] :components\enterprise\browser\controller\chrome_browser_cloud_management_controller.cc(163) Cloud management controller initialization aborted as CBCM is not enabled.
[28220:32052:1116/182248.330:WARNING:external_provider_impl.cc(513)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
tracing_subscriber - init success
[28220:32052:1116/182248.429:INFO:mod.rs(74)]   skus::sdk: skus sdk initialized, environment: production, version: "unknown"
[28220:32052:1116/182251.353:WARNING:brave_stats_updater_params.cc(129)] Couldn't find the time of first run. This should only happen when running tests, but never in production code.
[28220:32052:1116/182252.625:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 0, file size:97
[28220:32052:1116/182252.636:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 0, file size:97
..\..\brave\browser\brave_shields\ad_block_service_browsertest.cc(908): error: Expected equality of these values:
  true
  EvalJs(contents, base::StringPrintf("setExpectations(0, 0, 1, 1);" "xhr('%s')", resource_url.spec().c_str()))
    Which is: false
Stack trace:
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF6E66BD408+872] (C:\jenkins\x64-nightly\src\content\public\test\browser_test_base.cc:937)
	content::BrowserMainLoop::RunMainMessageLoop [0x00007FF6E4F4A2A6+246] (C:\jenkins\x64-nightly\src\content\browser\browser_main_loop.cc:1078)
	content::BrowserMainRunnerImpl::Run [0x00007FF6E4F4C201+17] (C:\jenkins\x64-nightly\src\content\browser\browser_main_runner_impl.cc:160)
	content::BrowserMain [0x00007FF6E4F4728B+155] (C:\jenkins\x64-nightly\src\content\browser\browser_main.cc:34)
	content::RunBrowserProcessMain [0x00007FF6E5906863+211] (C:\jenkins\x64-nightly\src\content\app\content_main_runner_impl.cc:707)
	content::ContentMainRunnerImpl::RunBrowser [0x00007FF6E5907DA1+1121] (C:\jenkins\x64-nightly\src\content\app\content_main_runner_impl.cc:1298)
	content::ContentMainRunnerImpl::Run [0x00007FF6E590786A+778] (C:\jenkins\x64-nightly\src\content\app\content_main_runner_impl.cc:1142)
	content::RunContentProcess [0x00007FF6E5906137+1159] (C:\jenkins\x64-nightly\src\content\app\content_main.cc:334)
	content::ContentMain [0x00007FF6E59062AD+125] (C:\jenkins\x64-nightly\src\content\app\content_main.cc:347)
	content::BrowserTestBase::SetUp [0x00007FF6E66BC7AC+2428] (C:\jenkins\x64-nightly\src\content\public\test\browser_test_base.cc:604)
	InProcessBrowserTest::SetUp [0x00007FF6E5D1C0E9+649] (C:\jenkins\x64-nightly\src\chrome\test\base\in_process_browser_test.cc:595)
[28220:32052:1116/182255.394:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 0, file size:97
[28220:32052:1116/182255.417:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 1, file size:0
[  FAILED  ] AdBlockServiceTest.SubscribeToCustomSubscription, where TypeParam =  and GetParam() =  (7167 ms)

[  FAILED  ] AdBlockServiceTest.SubscribeToCustomSubscription

brave-builds avatar Nov 16 '23 19:11 brave-builds

This test also fails with enabled dchecks. I'm going to disable it until the proper fix is applied.

Most likely the issue is: we need to await for download steps to complete before the test can proceed.

[ RUN      ] AdBlockServiceTest.SubscribeToCustomSubscription
[32436:27536:1207/062352.933:WARNING:chrome_main_delegate.cc(667)] This is Chrome version 120.1.63.0 (not a warning)
[32436:27536:1207/062352.979:ERROR:policy_logger.cc(156)] :components\enterprise\browser\controller\chrome_browser_cloud_management_controller.cc(161) Cloud management controller initialization aborted as CBCM is not enabled. Please use the `--enable-chrome-browser-cloud-management` command line flag to enable it if you are not using the official Google Chrome build.
[32436:27536:1207/062353.031:WARNING:external_provider_impl.cc(514)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
tracing_subscriber - init success
[32436:27536:1207/062353.362:INFO:mod.rs(71)]   skus::sdk: skus sdk initialized, environment: production, version: "unknown"
[32436:27536:1207/062353.377:ERROR:client_tag_based_model_type_processor.cc(116)] The persisted metadata was invalid and was cleared for Device Info. Start over fresh.
[32436:27536:1207/062356.052:WARNING:brave_stats_updater_params.cc(129)] Couldn't find the time of first run. This should only happen when running tests, but never in production code.
[32436:27536:1207/062357.631:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 0, file size:97
[32436:27536:1207/062357.650:WARNING:controller_impl.cc(1190)] Background download complete, client: 255, completion type: 0, file size:97
[32436:27536:1207/062357.696:FATAL:download_item_impl.cc(2343)] Check failed: !job_->is_paused(). At the time a download enters IN_PROGRESS state, it must not be paused.
	partition_alloc::internal::base::debug::CollectStackTrace [0x00007FF63A423822+18] (C:\ws\src\base\allocator\partition_allocator\src\partition_alloc\partition_alloc_base\debug\stack_trace_win.cc:97)
	base::debug::StackTrace::StackTrace [0x00007FF6401C58D2+18] (C:\ws\src\base\debug\stack_trace.cc:218)
	logging::LogMessage::~LogMessage [0x00007FF64025AFEA+186] (C:\ws\src\base\logging.cc:727)
	logging::`anonymous namespace'::DCheckLogMessage::~DCheckLogMessage [0x00007FF64027A952+50] (C:\ws\src\base\check.cc:86)
	logging::CheckError::~CheckError [0x00007FF64027A7D1+33] (C:\ws\src\base\check.cc:263)
	download::DownloadItemImpl::TransitionTo [0x00007FF63BAA9595+551] (C:\ws\src\components\download\internal\common\download_item_impl.cc:2343)
	download::DownloadItemImpl::OnTargetResolved [0x00007FF63BAAC601+671] (C:\ws\src\components\download\internal\common\download_item_impl.cc:1861)
	download::DownloadItemImpl::OnDownloadRenamedToIntermediateName [0x00007FF63BAAC7D7+391] (C:\ws\src\components\download\internal\common\download_item_impl.cc:1823)
	base::OnceCallback<void (unsigned int, const std::__Cr::basic_string<char,std::__Cr::char_traits<char>,std::__Cr::allocator<char> > &)>::Run [0x00007FF639E1F1A7+97] (C:\ws\src\base\functional\callback.h:155)
	base::internal::FunctorTraits<base::OnceCallback<void (media::DemuxerStream::Type, const std::__Cr::vector<media::DemuxerStream *,std::__Cr::allocator<media::DemuxerStream *> > &)>,void>::Invoke<base::OnceCallback<void (media::DemuxerStream::Type, const s [0x00007FF63B5FD6CA+54] (C:\ws\src\base\functional\bind_internal.h:792)
	base::OnceCallback<void ()>::Run [0x00007FF639DBAE27+83] (C:\ws\src\base\functional\callback.h:155)
	base::TaskAnnotator::RunTaskImpl [0x00007FF6401F8EA5+421] (C:\ws\src\base\task\common\task_annotator.cc:216)
	base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FF6420F0677+2007] (C:\ws\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:461)
	base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FF6420EF9A8+296] (C:\ws\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:335)
	base::MessagePumpForUI::DoRunLoop [0x00007FF6401A64B2+434] (C:\ws\src\base\message_loop\message_pump_win.cc:213)
	base::MessagePumpWin::Run [0x00007FF6401A5230+240] (C:\ws\src\base\message_loop\message_pump_win.cc:79)
	base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FF6420F1A88+616] (C:\ws\src\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:629)
	base::RunLoop::Run [0x00007FF64021C4C1+657] (C:\ws\src\base\run_loop.cc:136)
	content::MessageLoopRunner::Run [0x00007FF641897830+98] (C:\ws\src\content\public\test\test_utils.cc:331)
	content::TestNavigationObserver::Wait [0x00007FF64189898D+93] (C:\ws\src\content\public\test\test_navigation_observer.cc:131)
	ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete [0x00007FF63FF7081E+1461] (C:\ws\src\chrome\test\base\ui_test_utils.cc:296)
	ui_test_utils::NavigateToURL [0x00007FF63FF70243+29] (C:\ws\src\chrome\test\base\ui_test_utils.cc:231)
	AdBlockServiceTest_SubscribeToCustomSubscription_Test::RunTestOnMainThread [0x00007FF639DC93CC+4300] (C:\ws\src\brave\browser\brave_shields\ad_block_service_browsertest.cc:882)
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF6418BA9B6+966] (C:\ws\src\content\public\test\browser_test_base.cc:948)
	base::OnceCallback<void ()>::Run [0x00007FF639DBAE27+83] (C:\ws\src\base\functional\callback.h:155)
	content::BrowserMainLoop::InterceptMainMessageLoopRun [0x00007FF63DA53038+60] (C:\ws\src\content\browser\browser_main_loop.cc:1058)
	content::BrowserMainLoop::RunMainMessageLoop [0x00007FF63DA5306F+37] (C:\ws\src\content\browser\browser_main_loop.cc:1070)
	content::BrowserMainRunnerImpl::Run [0x00007FF63DA5534E+46] (C:\ws\src\content\browser\browser_main_runner_impl.cc:160)
	content::BrowserMain [0x00007FF63DA4F10F+175] (C:\ws\src\content\browser\browser_main.cc:34)
	content::RunBrowserProcessMain [0x00007FF63F45D165+353] (C:\ws\src\content\app\content_main_runner_impl.cc:707)
	content::ContentMainRunnerImpl::RunBrowser [0x00007FF63F45F4DE+1232] (C:\ws\src\content\app\content_main_runner_impl.cc:1298)
	content::ContentMainRunnerImpl::Run [0x00007FF63F45EE7E+1566] (C:\ws\src\content\app\content_main_runner_impl.cc:1146)
	content::RunContentProcess [0x00007FF63F45C8DB+1312] (C:\ws\src\content\app\content_main.cc:334)
	content::ContentMain [0x00007FF63F45CA2A+113] (C:\ws\src\content\app\content_main.cc:347)
	content::BrowserTestBase::SetUp [0x00007FF6418B9BFF+2703] (C:\ws\src\content\public\test\browser_test_base.cc:615)
	InProcessBrowserTest::SetUp [0x00007FF63FF72A77+439] (C:\ws\src\chrome\test\base\in_process_browser_test.cc:597)
	testing::Test::Run [0x00007FF63A592F67+127] (C:\ws\src\third_party\googletest\src\googletest\src\gtest.cc:2668)
	testing::TestInfo::Run [0x00007FF63A5939E8+316] (C:\ws\src\third_party\googletest\src\googletest\src\gtest.cc:2852)
	testing::TestSuite::Run [0x00007FF63A5941D4+350] (C:\ws\src\third_party\googletest\src\googletest\src\gtest.cc:3010)
	testing::internal::UnitTestImpl::RunAllTests [0x00007FF63A59E06B+715] (C:\ws\src\third_party\googletest\src\googletest\src\gtest.cc:5867)
	testing::UnitTest::Run [0x00007FF63A59DD13+209] (C:\ws\src\third_party\googletest\src\googletest\src\gtest.cc:5440)
	base::TestSuite::Run [0x00007FF64014BA36+166] (C:\ws\src\base\test\test_suite.cc:414)
	ChromeTestSuiteRunner::RunTestSuiteInternal [0x00007FF647FBB45D+53] (C:\ws\src\chrome\test\base\chrome_test_launcher.cc:91)
	ChromeTestSuiteRunner::RunTestSuite [0x00007FF647FBB4CB+75] (C:\ws\src\chrome\test\base\chrome_test_launcher.cc:96)
	ChromeTestLauncherDelegate::RunTestSuite [0x00007FF647FBB73D+205] (C:\ws\src\chrome\test\base\chrome_test_launcher.cc:145)
	content::LaunchTestsInternal [0x00007FF643C6F430+828] (C:\ws\src\content\public\test\test_launcher.cc:407)
	content::LaunchTests [0x00007FF643C6F91A+286] (C:\ws\src\content\public\test\test_launcher.cc:494)
	LaunchChromeTests [0x00007FF647FBBC71+281] (C:\ws\src\chrome\test\base\chrome_test_launcher.cc:333)
	main [0x00007FF647FBB39A+242] (C:\ws\src\brave\test\base\browser_tests_main.cc:66)
	__scrt_common_main_seh [0x00007FF648452AB8+268] (D:\a\_work\1\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
	BaseThreadInitThunk [0x00007FF841094DE0+16]
	RtlUserThreadStart [0x00007FF84187ED9B+43]
Task trace:
	download::DownloadFileImpl::OnRenameComplete [0x00007FF63BA9EA5F+271] (C:\ws\src\components\download\internal\common\download_file_impl.cc:476)
	download::DownloadItemImpl::OnDownloadTargetDetermined [0x00007FF63BAAC23B+1259] (C:\ws\src\components\download\internal\common\download_item_impl.cc:1796)
	download::DownloadPathReservationTracker::CheckDownloadPathForExistingDownload [0x00007FF63BAB2D42+158] (C:\ws\src\components\download\internal\common\download_path_reservation_tracker.cc:546)
	download::DownloadPathReservationTracker::CheckDownloadPathForExistingDownload [0x00007FF63BAB2D42+158] (C:\ws\src\components\download\internal\common\download_path_reservation_tracker.cc:546)
	DownloadTargetDeterminer::ScheduleCallbackAndDeleteSelf [0x00007FF641AF8D9A+712] (C:\ws\src\chrome\browser\download\download_target_determiner.cc:1133)
Task trace buffer limit hit, update PendingTask::kTaskBacktraceLength to increase.

goodov avatar Dec 07 '23 07:12 goodov

Can we close this one? Seems it hasn't happened in a while.

bbondy avatar Feb 16 '24 19:02 bbondy

@bbondy FWIW it's been disabled as of https://github.com/brave/brave-core/commit/acb61af56bc18139ad1f809c61ba11b79e1a534e

antonok-edm avatar Feb 16 '24 19:02 antonok-edm

ah that explains why it is not occurring. Thanks.

bbondy avatar Feb 16 '24 20:02 bbondy

In cases like this, I'd suggest keeping the issue open only if it's going to be fixed soon. Otherwise, I'd close it. We do keep track of what's disabled and get weekly reminders (like this one).

wknapik avatar Feb 22 '24 17:02 wknapik

@goodov is this something you can take a look at and pick up? Otherwise, let's close this one and we'll keep in the disabled list for now.

rebron avatar Mar 11 '24 16:03 rebron

@goodov is this something you can take a look at and pick up? Otherwise, let's close this one and we'll keep in the disabled list for now.

Someone from the AdBlock team should look into this. Leaving a flaky test in a disabled state is not different from removing it. If AdBlock team doesn't have resources to fix it or doesn't think this test is important, let's just remove it.

goodov avatar Mar 12 '24 06:03 goodov

Closing.

rebron avatar Jun 03 '24 16:06 rebron