Michael Wayne Goodman
Michael Wayne Goodman
I second the request for a changelog. ~~Maybe this issue can be repurposed to track that?~~ *edit: just saw #216*
@alvations yes, it is indeed very free, for better or worse. There are some things which can be checked easily, such as having a `ARG3` on a concept that does...
Renaming this as some transformations are already implemented in the `penman.transform` module, but not to the extent that this issue describes.
For logging verbosity: the `-v` option is shared by all commands, but for `mkprof` there are no logging calls in the command code nor in the underlying `delphin.tsdb` module, so...
Ok thanks, I see the error when an `i-input` field is empty. > If you guide me suggesting how to add the loginng and better try/catch in the profile creation,...
I have released v1.6.0 already, so I've removed this issue from the milestone. I'm happy to put it in a 1.6.1 patch release.
As a hint, the problem is here: https://github.com/delph-in/pydelphin/blob/77fc995f1208a06c9eafd18c2218851fb45d8eac/delphin/commands.py#L423-L424 Line 424 assumes that `colmap['i-input']` will be a string, but it's `None` when the column is empty, so this needs to be...
This is odd. I suspect the `Sense.synset()` method is not creating a synset object in the same way as via the `Wordnet.synsets()` method, and then the `hypernym_paths()` method attempts to...
Looks like my guess was correct. Here is `Sense.synset()`: https://github.com/goodmami/wn/blob/a832a63321c20492a8be9f0bb3308ad3a684a516/wn/_core.py#L896-L905 Note that it calls the module function `wn.synset()`, without any limits on the lexicons. The resulting, unconstrained synset will then...
@fcbond just checking in. Do you think you can do this, or shall I?