Gary O'Neall

Results 1059 comments of Gary O'Neall

In the case where you have white space involved in the matching, I would prefer to update the license list XML matches to include the words surrounding the white space...

The POM file already has version 0.12.0 specified before Jena dependency. For some reason, 0.10.0 is still being included in the executables. Perhaps someone more familiar with POM files could...

> This would speed up rejections but slow down positive matches. This particular methods loops through all listed licenses, so for each positive match there will be several hundred negatives,...

@aviral1701 I should have referenced the method with the iteration above. Here's the method with the iteration: https://github.com/spdx/tools/blob/fcdf7d243b7a66288de3630c56324e6dde4ff74c/src/org/spdx/compare/LicenseCompareHelper.java#L606 A suggestion on implementing a solution - the `isTextStandardLicense` method is called...

Looking back on @wking post above, there is a good point: > Currently license-list-XML's match validation is generating a lot more positives So, perhaps we should move the performance optimization...

@aviral1701 Sorry about the delayed response - I was traveling and just got back to a location where I can access github without issue. > 1.) how do you want...

@vlsi Good point - there really isn't a need to tokenize the template each time. Perhaps we can change the design to store a tokenized version of the license template...

There is a related SPDX spec issue https://github.com/spdx/spdx-spec/issues/414

@alpianon Thanks for the detailed information. After a bit of digging, I think I found the cause of the false positives. The Libtool-exception is not a license, but an exception....