Gary O'Neall

Results 1059 comments of Gary O'Neall

@dholth can you rebase this PR to the latest in the main branch? This should fix the CircleCI errors.

Thanks @bjamesv for the extensive PR! Very much appreciated. I did a review primarily for the spec - I'm not much of a Python programmer, so I won't be much...

> This correction was proposed in Nov. 2021 [PR #197](https://github.com/spdx/tools-python/pull/197/files#diff-e5c5d02a8791ee55274c6d52d412ff91c8a176286403766171f48d216e10ba7eR521-R544) (Issue https://github.com/spdx/tools-python/issues/184). @goneall can you rebase https://github.com/spdx/tools-python/pull/197 on main HEAD and see if the actions pass/review can be concluded? I...

@ppalaga Currently, the SPDX maven plugin can aggregate licenses, but it requires configuring the licenses in the POM file for the project which is admittedly a very tedious effort of...

There is an `spdx:licenseConcluded` and `spdx:licenseDeclared` associated with the SPDX package itself. The licenseDeclared is what was found in the Maven POM file for the originating package while the licenseConcluded...

@Gautime This one is bit complex. The starting point would be the [SpdxNoAssertionElement](https://github.com/spdx/tools/blob/master/src/org/spdx/rdfparser/model/SpdxNoAssertionElement.java) class and the [SpdxNoneElement](https://github.com/spdx/tools/blob/master/src/org/spdx/rdfparser/model/SpdxNoneElement.java) class.

The same issue occurs for the SpdxNoneElement. Related SPDX elements which have a value of none is currently generated as: ``` ``` It should be represented as: ``` ```

> How can I reproduce the output? It seems we don't have No assertion related elements in example rdf file. You can run the utility [tag to RDF](https://github.com/spdx/tools/blob/master/src/org/spdx/tools/TagToRDF.java) on the...

@Gautime The problem is just a bit deeper in the design. The [SpdxNoAssertionElement](https://github.com/spdx/tools/blob/master/src/org/spdx/rdfparser/model/SpdxNoAssertionElement.java) class and the [SpdxNoneElement](https://github.com/spdx/tools/blob/master/src/org/spdx/rdfparser/model/SpdxNoneElement.java) would need to be changed (most likely). `printRelationship` isn't used to produce the...

> Can't we fix this here (vs. in license-list-XML) by adjusting the license regexps if necessary? I'd rather not break the XML to work around a tooling issue. I would...