Gary O'Neall

Results 1059 comments of Gary O'Neall

With PR #1159 - can we consider this resolved?

@JPEWdev - let me know if I'm on the right track and if this is usable for the HTML generator BTW - decided to write the example by hand -...

It looks like the CI is tripping on the external Agent reference - not sure if this is an issue with the source or the validator

> pyshacl failed. It can't handle external IDs. > > I have tried spdx3-validate the example, it is valid. > > If spdx3-validate can already handle SHACL validation, we may...

> Wonder if eventually we have to update all the SPDX IRIs from "3.0.1" to "3.0" ? > > According to issue [spdx/spdx-3-model#1046](https://github.com/spdx/spdx-3-model/issues/1046) The context file currently refers to the...

> @goneall may I suggest to move this to the model repo? > > Having it in the spec repo would make it harder to keep it in sync whenever...

Note: If I add any properties to an Extension class, the resultant JSONLD file fails schema validation. Here's a snippet that causes the failure: ``` { "spdxId" : "https://spdx.github.io/spdx-spec/v3.0.1/examples/full-example-eaa46bdcfa20#document", "type"...

The example should have all classes except: - Extension - due to validation issue - ~~ExploitCatalogVulnAssessmentRelationship - due to an inconsistency with the locator property between the Java generated code...

Note that this was generated with a significant amount of manual work and a lot of copy/paste - so I would be shocked if it didn't have any errors. I...

ExploitCatalogVulnAssessmentRelationship is now in the example