Nazar Gondaruk
Nazar Gondaruk
Looks like before gcc was introduced, `target_bitrate` was used in calculation which was [always](https://github.com/centricular/webrtcsink/blob/64f664c859af180679bebc10ed44ee78793d54f5/plugins/src/webrtcsink/imp.rs#L1024)
Hmm. My bad. `bitrate` in this context is estimated bitrate notified by `rtpgccbwe`. Maybe, you're right and `rtpgccbwe` should not estimate more than `max_bitrate`?
@MathieuDuponchelle sorry for confusion. I should have check deeper before doing PR. Here is what I found. If `do_fec` is set to true - `rtpgccbwe`'s `max-bitrate` [will be](https://github.com/centricular/webrtcsink/blob/main/plugins/src/webrtcsink/imp.rs#L1367) `max-bitrate *...
Thanks! Let me work on that and I'll get back :)
Hey @MathieuDuponchelle @thiblahute, whenever you have a chance, could you please take a look on the update and let me know if it's what you meant or if I misunderstood...
@thiblahute @MathieuDuponchelle, whenever you have a chance, could you please take a look? Thanks :)
Updated PR heading to reflect what was implemented at the end. Let me know, if I can do anything else to get this merged. Thanks :)
@MathieuDuponchelle, kindly reminder about this PR :)