Péter Gömöri

but let me know if this is a totally bad idea, I am ready to accept that :)

thanks Roberto I don't think els_parser handles standalone comments anywhere (https://github.com/WhatsApp/erlfmt/blob/main/src/erlfmt_recomment.erl#L98) at least I did not expect them :) as an alternative of fixing els_parser: @michalmuskala would it be possible...

makes sense. Will need to test the parser on more "final comments in containers", there might be other problematic places then records. (the record part is not a big change,...

very nice! just minor note that currently there is no folding_range POI created for one-line functions. These are usually short and the formatter wouldn't break them up, but there might...

hi Roger, thanks for the report erlang_ls uses rebar3_format's default_formatter under the hood, and it did have this issue (https://github.com/AdRoll/rebar3_format/issues/74) but it seems to be fixed since version 0.8.0. rebar3_format...

very interesting, I wasn't aware of tree-sitter. Isn't it a bit of competing with LSP in that an editor with a generic tree-sitter plugin and a language specific grammar can...

I have some doubts how efficient this can be. But it's simple enough to try. It can for example eliminate the last incomplete expression for a function body. I wonder...

good point Michal, what I did in some draft commit is to store some of the range info from the erlfmt AST in the Anno part during conversion in `els_erlfmt_ast`....

I think the dir structure can be tackled with appropriate path configs, but having include files (or modules) with the same name in the same erlang_ls project is a problem...

We do store variables and atoms from parsable forms. The proposed commit only adds more data for unparsable forms, so I don't think this causes noticable difference for any project...