Pablo Gómez
Pablo Gómez
Just stumbled on this, you can have both fairly easily with https://github.com/jcmgray/autoray :) Also allows for a numpy-like API , see e.g. here https://github.com/FHof/torchquad/blob/develop/torchquad/integration/trapezoid.py
I changed PR base as new features go into develop first :pray:
Just request a review when I should review this!
(switched base to refresh diff)
@elastufka First off, thank you for your efforts! The code looks very well structured and fits in neatly! A few thoughts to integrate seemless with CI, current version etc.: -...
(I will wait for your reply before I dig in deeper)
@elastufka Great to hear! I would suggest to branch out from #137 because this introduces quite some changes in the codebase (and by following the other integrators there your implementation...
> One thing that wasn't quite clear from the documentation/code - are the inputs x to the integrals preferentially tensors, or numpy arrays? Well the integrand function is user-defined, so...
@sebastienwood could this maybe help? https://torchquad.readthedocs.io/en/main/tutorial.html#speedups-for-repeated-quadrature
Ah ok, I think I am starting to see what you mean. So, the problem is a bit outside of the classic domain where you would look for speedups. For...