Vadym Holoveichuk
Vadym Holoveichuk
`allowJs` should help
it's reproducing on both 2.9.1 and 2.9.2 I've tried to find what a problem, used console.log on compiled atl, function `compiler.createWatchProgram(watchHost);` doesn't return.
I'm sorry, I forgot to exclude node_modules, works fine on 2.9.2
added one simple test
@evanw could you please check if this is smth that could be merged?
rebased
Could you send a test case?
If I remember correctly, and looking at the docs, dynamic import expression is allowed in cjs modules. https://nodejs.org/api/esm.html#import-expressions My target is to support cjs, so this is ok to have...
@evanw gentle ping.
Hey, big thanks for work. I've checkout https://github.com/nodejs/node/pull/38905 and applied https://bugs.chromium.org/p/v8/issues/detail?id=12921 patch on top of it. Generally it works good, but I found another segfault. It seems like it's related...