Misha Golenkov

Fix H5P resizer (stable branch)

1

This is a formal pull request for the stable branch to fix #314 . This has been successfully merged and tested in Production environments. Catalyst stable branch with this fix...

After configuring CF as described [https://github.com/catalyst/moodle-tool_objectfs/blob/master/CLOUDFRONT.md] I had an error with H5P activity https://h5p.org/virtual-tour-360: ``` Access to image at 'https://my_cf_domain.cloudfront.net/ce/15/ce157b693b885b670fbb7c3f7e938d6b1993b7c4?response-content-disposition=inline%3Bfilename%3D%22scenesrc-5c6528d79e311.jpg%22&response-content-type=image%2Fjpeg&Expires=nnnnnnnnnn&Signature=xxxxxxxxxxx&Key-Pair-Id=yyyyyyyyyyyyyy' (redirected from 'http://localhost/pluginfile.php/1/core_h5p/content/1/images/scenesrc-5c6528d79e311.jpg') from origin 'http://localhost' has been blocked by...

Image preview cause pulling images from external storages

2

Objectfs pulls files locally each time when `get_local_path_from_hash()` method gets invoked. This method is used to preview images and get their width, height and mimetype. So even if pre-signed urls...

Running phpunit with `$CFG->phpunit_objectfs_swift_integration_test_credentials` defined I'm having this: ``` 1) tool_objectfs\tests\checker_testcase::test_checker_get_location_local_if_object_is_local Error: Class 'tool_objectfs\tests\test_swift_integration_client' not found /siteroot/admin/tool/objectfs/tests/classes/test_file_system.php:71 /siteroot/admin/tool/objectfs/classes/local/store/object_file_system.php:61 /siteroot/admin/tool/objectfs/tests/tool_objectfs_testcase.php:38 /siteroot/admin/tool/objectfs/tests/checker_test.php:33 /siteroot/lib/phpunit/classes/advanced_testcase.php:80 To re-run: vendor/bin/phpunit -c admin/tool/objectfs/ "tool_objectfs\tests\checker_testcase" admin/tool/objectfs/tests/checker_test.php ERRORS! ```...

When running `php admin/tool/phpunit/cli/init.php` I get: ``` PHP Fatal error: Class 'MicrosoftAzure\Storage\Common\Internal\Resources' not found in /siteroot/admin/tool/objectfs/classes/local/store/azure/file_system.php on line 37 PHP Stack trace: PHP 1. {main}() /siteroot/admin/tool/phpunit/cli/util.php:0 PHP 2. phpunit_util::install_site() /siteroot/admin/tool/phpunit/cli/util.php:150...

Another issue that looks to be CF configuration issue. Error: ``` InvalidArgument Only one auth mechanism allowed; only the X-Amz-Algorithm query parameter, Signature query string parameter or the Authorization header...

Screenshot: 

- Create patches for every supported version (including patches for phpunit) - Update Travis to use these patches

This is to enhance readme and add explicit instructions of `admin_setting_filetypes` class backporting (backport MDL-53240 tracker or create a patch). Issue #282 was fixed by checking if `admin_setting_filetypes`, but it...