Adam Goldman

Results 47 comments of Adam Goldman

After poking around the code a bit, I tried to hack it like this: ``` zdApi.requestAll( "GET", "users/list?role[]?=admin&role[]=agent", ) ``` but it isn't exposed on the client

A nice API could be: ``` zdApi.users.list({options}, cb) // i.e. zdApi.users.list({role: ["agent", "admin"]}, cb) ```

Seems like `cypress run` only takes screenshot of the visible screen, and `cypress open` scrolls and screenshots the entire page I recorded now using `cypress open` and then did `cypress...

hmmm ... recording with `cypress run` didn't wait for content to load, while `cypress open` did. Maybe that's why there's such a difference in image height. ![init diff](https://user-images.githubusercontent.com/6963212/62466914-2b8d3880-b79b-11e9-84ad-79abc0e6c9ba.png) I will...

I changed the capture to viewport: `addMatchImageSnapshotCommand({ capture: 'viewport' })` so both tests are same dimensions, but they are still failing, tho I don't see any difference in the diff...

I ran it in gitlab ci, and there's a mismatch between the images taken by the ci and taken locally, with the same cypress command `cypress run`

@sebinsua the failure percentage varies from 5-28(!) percent :/ your solution disables the image matching in a headed electron browser? This means it won't compare the snapshots when I do...

Also tried adding this file with no effect: ``` // .postcssrc.js module.exports = { modules: true, plugins: { "postcss-modules": { generateScopedName: "[folder]__[local]___[hash:base64:6]", }, }, } ```

sure, here it is: https://github.com/goldylucks/browser-extension-template thanks for the help and getting back to me so promptly!

but if I rename the file the collision will just happen for the new name no? or am I missing smthn here?