tools

tools copied to clipboard

cmd/present: Make subsections usable on slides

3

This PR fixes two issues that make using subsections in presentations awkward: * When using position:absolute, H2 section headers all crowd 150px from the bottom of the slide, making the...

farhaven

go/analysis/passes/errorsas: support other packages

1

errorsas now supports other packages. By default, it checks github.com/pkg/errors and golang.org/x/xerrors, but additional packages can be passed via -pkgs flag. Fixes golang/go#44784

ShoshinNikita

go/analysis: enable change ssa.BuilderMode on buildssa Analyzer

6

Hello👋 This PR proposes to enable change ssa.BuilderMode on buildssa Analyzer. Since there is currently no way to change `BuilderMode`, I created a public function `CreateRunner` so that it can...

sanposhiho

cmd/stringer: add more control over generated String output through comment

3

The change suggested is to address the use case, where constants have to be public (capitalized), and the output is expected to be camelCase. The idea is that the flags...

zzwx

Fix example of specifying value received method in `-funcs`

4

My experimentation shows that `dir/pkg.Type.Method` doesn't work, but `(dir/pkg.Type).Method` does. Looking at https://golang.org/pkg/go/types/#Func.FullName implementation: https://github.com/golang/go/blob/18bcc7c2854f900dfb631d7ef01a839021e24576/src/go/types/object.go#L465-L486 it seems to me that in both cases of pointer and value received the brackets...

rutsky

go/analysis/analysistest: Ignore error if edited file can't be formatted

8

There are instances when the diagnostics are reported correctly by the analyzer, but the suggested fixes are wrong, and result in code that cannot be formatted by `format.Source` (due to...

sourya

clear screen before rendering images

1

clear screen before rendering images. this allows users to render multiple images. Currently it will just display IMAGE: 

drewbailey

Fix a test related to cyclic import error

4

TDLR: In the PR https://github.com/golang/go/pull/68337, we added more info in the error stack, it needs a change in x/tools'test too. Before: golang.org/fake/a golang.org/fake/b golang.org/fake/a After: golang.org/fake/a golang.org/fake/b from a.go golang.org/fake/a...

xin-tsla

go/packages: do not nullify Fset when NeedSyntax is set

5

Currently, Fset is initialized when either NeedTypes or NeedSyntax are set in newLoader(). However, later in refine() it is nullified using a different condition that doesn't take NeedSyntax into account....

edigaryev

x/tools/go/analysis: Add end position if present for the analysis JSON output for Diagnostics

19

To add end position if present for the analysis JSON output

madneal