tools
tools copied to clipboard
golang
go/analysis/analysistest: Ignore error if edited file can't be formatted
There are instances when the diagnostics are reported correctly by the
analyzer, but the suggested fixes are wrong, and result in code that
cannot be formatted by format.Source (due to errors in the edited code).
Right now, in those cases, the tests pass despite the format errors.
This commit fixes that.
Signed-off-by: Sourya Vatsyayan [email protected]
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
This PR (HEAD: 814f4d8b1b01c16d1ec339f8c49fa13354e429a2) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/236144 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/236144. After addressing review feedback, remember to publish your drafts!
Message from Michael Matloob:
Patch Set 1:
I think it's definitely a problem that we don't even check suggested fixes if the file can't be formatted, so I think that instead of just continuing we should check against the unformatted code.
It's tricky to just outright fail if the file can't be formatted. Consider a file that has a syntax error, and someone makes a resilient analyzer that can make suggested fixes even in the presence of syntax errors. This change could make it difficult to test an analyzer like that.
Please don’t reply on this GitHub thread. Visit golang.org/cl/236144. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 4f09fe55bcede8d4387295e5d14c114cf08acb46) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/tools/+/236144 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Michael Matloob:
Patch Set 3:
Hm, I'm not sure if this is right either. Most likely the message will be ignored.
I'm wondering if we can do the following: if the file fails to format, we check if the original file was able to be formatted: a suggested fix shouldn't break previously working code.
Please don’t reply on this GitHub thread. Visit golang.org/cl/236144. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/236144. After addressing review feedback, remember to publish your drafts!