Galen O’Hanlon

Improve warning about view snapshot discrepancies

1

I think it's better to be conservative, as the list of variables that can cause discrepancies is incomplete and unlikely to ever be exhaustive. Other things that seem to cause...

Using `pip install -r requirements.txt` with the included requirements was enough for me to run `python encoder.py` in a clean Python 3.6.1 install. Note that I also specified the Python...

`AttributeRemover` outputs a leading newline in some cases

1

### Description #2247 better isolates the `AttributeRemoverTests` to just `AttributeRemover`. Along the way, a new assert helper was created that, unlike `assertMacroExpansion`, doesn't trim newlines before comparing values. Notably, this...

Fix-it coverage lost when macros include diagnostics with and without fix-its

1

### Description `assertMacro` only applies fix-its when _all_ emitted diagnostics have one or more fix-its, so fix-it coverage is lost when macros include diagnostics with and without fix-its. Instead, fixes...

Exclusively applicable fix-its aren't testable

5

### Description I have a diagnostic with several fix-its, where only one can be applied. Here's the usage, and note that, while `diagnostics` is correct and (very!) useful, both `fixes`...

### Description Swift provides non-public initializers that default optionals to `nil`. A design tenet of MemberwiseInit has been to strive to be a pure superset of Swift's memberwise initializer, and...