Asmir Mustafic comments

Results 550 comments of


                                            Asmir Mustafic

Make dependency doctrine/annotations optional

I'm fine in doing something as in jms serializer. a small bc break but it allows us to move forward. for sure some people will complain, but i will be...

Traverser::node() does not handle entity references

hm, interesting. are you willing to provide a fix for this?

Fix deprecations triggered since twig 3.12.0

Sorry for the delay

Parser remove the single < (less than) character from given html string

hi, if the solution mentioned there works, can you provide a PR?

HTML5 specification parser differential

I was partially aware of such issues, are you willing/able to provide a fix for some of the issues you mention?

Duplicate attributes are not handled the same than in the HTML specification.

is anyone willing to provide a fix for this issue?

Enhancement: Adds return types on `ClassMetadata` serialization methods

can you please check phpcs failures?

Type error in `UnionHandler`

>Unfortunately, it breaks existing code @scyzoryck would it make sense to revert the union types thing that is causing this error? from my understanding, https://github.com/schmittjoh/serializer/pull/1546 is the guilty one, right?

Type error in `UnionHandler`

> Soo, personally I would go with fixing the issues, and going with the fix release this week with support for missing types. :+1:

Type error in `UnionHandler`

@scyzoryck adding `enableUnionSupport` makes sense, it seems that there is much more work than expected to have it working properly. It would be good to revert https://github.com/schmittjoh/JMSSerializerBundle/pull/954 as well