html5-php
html5-php copied to clipboard
Published
20 hours ago •
Masterminds
Masterminds
Traverser::node() does not handle entity references
If I manually modify a DOM document and add an entity reference, HTML5::saveHTML() does not give the same result as DOMDocument::saveHTML():
$html5 = new Masterminds\HTML5(['disable_html_ns' => TRUE]);
$dom = $html5->loadHTML('<body>');
$node = $dom->getElementsByTagName('body')->item(0);
$node->appendChild($dom->createElement('span', 'Identité'));
print $dom->saveHTML() . "\n";
print $html5->saveHTML($dom) . "\n";
outputs
<!DOCTYPE html>
<html><body><span>Identité</span></body></html>
<!DOCTYPE html>
<html><body><span>Identit</span></body></html>
This was reported in the Drupal project, which has recently switched to using this library instead of using DOMDocument to parse and serialize HTML: https://www.drupal.org/project/drupal/issues/3416204
This is because Traverser::node() does not handle XML_ENTITY_REF_NODE. Should the switch statement and rules class be extended to support this case?
