Asmir Mustafic comments

Results 550 comments of


                                            Asmir Mustafic

Groups is not used for Model naming in array property of object

> Actually using "Default" and no group is different in serialization. No group will include all fields regardless of their group, "Default" will only include the fields which don't have...

Adding a public method on a non-final class is to be considered a BC break

as @Majkl578 said, adding bc breaks in this case is correct but a bit pedantic. What abound introducing "optional" rules where the user can opt-in? (based on their BC promise)

Adding a public method on a non-final class is to be considered a BC break

> (see #52) great

Add nullable strict types for native and simple arguments

@rvdbogerd this looks good to me. is it ready? if yes, i can merge it right away

Fix masterminds-html5 lib php8-1 notice return type use phpstan

This library aims to be compatible with php 5.3, this return types are not supported

Add <body> if it's missing

@stof would you mind helping me with this ? what do you think about the change?

Add <body> if it's missing

I think that this has been figured out, can you please review it again?

"Allowed memory size of XXXXXXXXX bytes exhausted" when reading some XLS files

I have a similar issue. The culprit is the auto filter. I have a spreadsheet with ~10 worksheets each of them ~1000 rows. With autofilter the memory usage is ~2000MB,...

"Allowed memory size of XXXXXXXXX bytes exhausted" when reading some XLS files

i did investigate a little more. the issue is that my range is defined as `A1:A:100000`, that forces the filter to iterate over all the rows in the range and...

"Allowed memory size of XXXXXXXXX bytes exhausted" when reading some XLS files

`\PhpOffice\PhpSpreadsheet\Worksheet\AutoFilter` line 1053.