Richard Godden
Richard Godden
I think this issues might be fixed by PR #225 that just got merged
Thanks for pointing this out. I don't think a git clean will work if you have UpdateGitignore true. I'll take a look and see if there's anything we can do....
Ah nice -X. I wasn't aware of that flag thanks for that
Thanks for this. Im taking a look at it now and while it initially seems reasonable there are a few things I want to check before approving.
We are also seeing this. We are also using phabricator
Do we want to try to merge this? @Tatskaari
ref #270
One thing I noticed is you were adding support for aws json so this may need to be added to the list of things which need aws json support
> @goddenrich Thanks for working on this! I really appreciate it. As you pointed out we're in the middle of the JSON upgrade. We're not merging any PRs against master...
fyi @Admiral-Piett Ive mostly refactored things to follow the aws json feature work. I have also rebased this onto that feature branch. I still need to add smoke tests but...