Mike Schore

You need to be absolutely sure of the lifetime of these strings if you're going to pass them as references. `main` is used to spawn a new thread, and the...

This is very impressive, and overall looks like a good setup. Thank you, @danzh2010! I'm not terribly concerned, just curious: is spawning a thread per outstanding cert validation something that...

I'm guessing `platform_name` is the runtime key needed to look up the API bindings? If it is, that's great, but maybe the name is a bit misleading. If not, we...

For this use case, I think hardcoding is fine, especially given that there will only ever be one implementation in use per Envoy Engine. The name can just be baked...

The good news here is that Envoy already has support for certificate pinning. All that should really be needed to support this is plumbing.

Just wanted to check in on the status here - looks like there's a failing check, though it may be spurious? (I didn't happen to look.) If this is ready...

Just to chime in, I like @alyssawilk's suggestion here.

I think we just need to dump this logic, cc @junr03.

Until this issue is resolved, EM's signal handling may be disabled with the compile flag `--define signal_trace=disabled` (at the risk of introducing shutdown crashes).

Will be filing tracking issues, but here is the doc covering what I've found: https://docs.google.com/document/d/19-RFtfoQk7d1xrUq4BaG9Ltju6iXga1JX0z6_EK2F_8/edit?usp=sharing