Greg Price

Results 224 comments of Greg Price

What version of Firefox is that built on? MDN says BigInt has been in Firefox since version 68: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#browser_compatibility That's pretty old, from 2019. The Firefox ESR releases have been...

Cool. I think the right solution here is that Zotero should upgrade to use a version of Firefox that's still supported by Firefox upstream. For Firefox ESR, that's currently Firefox...

Cool. I haven't read the whole documentation, but this seems like a good idea that I'm glad someone is trying to standardize (it looks like a very recent Internet-Draft, so...

@lyind It may well be! (Speaking as a colleague of this issue's reporter.) Thanks for spotting that connection.

The Travis failure comes from coverage, saying that `static/js/common.js` is no longer 100% covered. @YJDave, you said on #5614 : > I am writing tests for function which I have...

Thanks @YJDave ! Playing with this in my dev environment, a few small tweaks: * Sometimes it says "Crack Time : less than less than a second". The double "less...

One suggestion in that thread that I think would be valuable to follow up on: WordPress appears to be using zxcvbn and enforcing a requirement with it. It'd be good...

Thanks @ryanle42 ! I've asked @brockwhittaker to review this PR -- he'll be better able to give you specific pointers on how to finish this.

Thanks @umairwaheed ! A few high-level comments: * Let's actually generate an encryption key per device, instead of per user. This (a) seems like the more appropriate security model to...

One other thing we can do, which will just make this a little easier to do future development on: Let's take whatever reCAPTCHA sitekey and secret you're using, and put...