Nathanael Noblet

Results 59 comments of Nathanael Noblet

I assume you mean the web ui? If not could you elaborate where the slowness comes from? It'll also be pretty difficult for us to figure out/reproduce where the issue...

I don't think that is the only JS either. Could you let us know if the slow down is due to trunk8.js ? Leave the other JS in place but...

This package is barely maintained. If you have a PR I can review and tests pass I can merge it but I haven't had time to do much here for...

This looks like a slam dunk - I'm wondering 2 things however. * Can you include as part of this a test case that fails when this isn't applied *...

So label in menu builders are extracted by default but the issue is that it doesn't detect the domain. There is a workaround. This is untested but this is a...

https://github.com/schmittjoh/JMSTranslationBundle/blob/master/Translation/Extractor/File/FormExtractor.php#L155 is the code that tries to find the translation_domain text within a php file. Based on my initial read its looking for an array translation_domain=>'domain' which wouldn't catch the...

Hello, I like this PR, Could you redo the tests as a separate form type / test? That way each test doesn't modify lines of source files of previous tests...

Its also related to #276