JMSTranslationBundle icon indicating copy to clipboard operation
JMSTranslationBundle copied to clipboard

Published 20 hours ago • verified publisher icon schmittjoh

Domain annotation form extractor

Open Pol-Valentin opened this issue 10 years ago • 5 comments

Add suport for @Domain{"domain"} and @Domains({"domain_one", "domain_two"}) on FormExtractor. I use these annotations for FormType use in admin and frontend with different domain translation.

Pol-Valentin avatar Nov 14 '14 15:11 Pol-Valentin

This is a bit related to https://github.com/schmittjoh/JMSTranslationBundle/issues/235.

cmfcmf avatar Mar 24 '16 09:03 cmfcmf

Hello, I like this PR, Could you redo the tests as a separate form type / test? That way each test doesn't modify lines of source files of previous tests etc. Makes merging multiple PRs easier.

gnat42 avatar Apr 26 '16 21:04 gnat42

Its also related to #276

gnat42 avatar May 31 '16 21:05 gnat42

Hello, I will extract my test this week.

Pol-Valentin avatar Jun 01 '16 08:06 Pol-Valentin

Sorry, I was not notified when you pushed to this PR. I like it. Thank you.

I have a suggestion: Lets merge the annotations to one Domain annotation.

Otherwise Im happy to merge this!

Nyholm avatar Aug 04 '16 15:08 Nyholm