Ernesto García comments

Results 235 comments of


                                            Ernesto García

refactor: Rework modal padding

> If you only look at differences in vertical spacing (the main concern of this PR), the middle image looks closer to the Figma mock, right? I agree. But only...

Vitest typings for jest-dom are broken in 6.6.2 when using "globalMode"

Fixed in #646

jest-dom/types/matchers-standalone.d.ts:9:3 - error TS2300: Duplicate identifier 'toHaveClass'.

> Suggested solution: Would you mind opening a PR to introduce that change?

fix: preserve state when location prop changes

@MichaelDeBoey (just because I do not know who else to ping and I saw you active at reviewing other PRs in this repository) Any chance I can get some feedback...

Streaming response support

Any plans to support this?

feat: add toBePressed matcher (#203)

@all-contributors please add @kretajak for code, test

Property 'toHaveTextContent' does not exist on type 'Assertion<HTMLElement>'.

Does https://github.com/testing-library/jest-dom/pull/621 fix the problem? If I understand correctly, this is something that consumers of the library would need to do in their own repos, so all we can do...

Property 'toHaveTextContent' does not exist on type 'Assertion<HTMLElement>'.

Can you make a review of that PR and request/suggest changes?

toHaveStyles doesn't work with a CSS variable

I won't be able to look into this any time soon, folks. Sorry. Contributions are welcome, though. And remember that **a contribution need not be necessarily a PR that fully...

Event content recreated on each rerender

> see [this comment in another issue](https://github.com/fullcalendar/fullcalendar/issues/3003) for more details. the link does not point to a comment in that other issue, but to the issue itself. Can you clarify...