Ernesto García

Results 235 comments of Ernesto García

To add more context, we allow `label={null}` because the type of `TextField` is `React.ReactNode` and not just a string. And that's a more idiomatic way to explicitly say "I know...

This is a valid issue. It seems that jest-dom does not implement this part of what's [documented in MDN](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-required): > When form controls are created using non-semantic elements, such as...

> I just wanted to confirm whether adding a new function in [to-be-required](https://github.com/testing-library/jest-dom/blob/main/src/to-be-required.js) file that checks if the element has `aria-required` with the value true should do the job, right?...

@anaf sorry for the very late response. I was reviewing old issues in Reactist and realized this question slipped through the cracks. Here's a list of the current uses of...

To be honest, this seems to be not too justified. The alternative way of checking it using `.toHaveAttribute` should be enough. I'm open to hear counter-arguments, in case I'm missing...

@jmvtrinidad I hear you. However, I am torn between what you said and an explicit goal in our own guiding principles stated in the README: > this library aims to...

Thanks. I'm going to go ahead and close this, which does not preclude the conversation to continue if someone still objects. **Conclusion:** using `toHaveAttribute` is a good enough substitute for...

Thanks for insisting. Indeed, I've changed my mind. I now see value in this matcher due to the fact that it should also check if the element in question is...

Sure, we do. Check out the "contributing" guide: https://github.com/testing-library/jest-dom/blob/main/CONTRIBUTING.md And let me know if you need more help or something's not clear. We can always improve that document if something...

I spent a few minutes after my first use of virtuoso trying to figure out why it was calling `itemContent` with indices that were out of range for my grouped...