Ernesto García

Results 235 comments of Ernesto García

Wow yes, now I see it. Thanks! One nit-pick: I'd call the third category "Checking form controls" because some of them can be used outside forms (e.g. buttons are everywhere...

Exactly. `toHaveTextContent` does [a bit more](https://github.com/testing-library/jest-dom/blob/8e14dc18b6229602c24b8f31adbdbe68cea3cc70/src/to-have-text-content.js#L11-L13) (see #21 and #56). And in case someone's wondering about the simplicity of the implementation of `toBeEmpty` (it can easily be done with `expect(element.innerHTML).toEqual('')`),...

I haven't checked again, but I recall that there was a previous complaint that `toHaveStyle` did not work with combined CSS properties. That is, that you had to use the...

So you want to validate that `animation-name` contains `scrollLeft`, but without having to mention that `fadeIn` is also in the mix. Is that it? --- Regardless of your answer, my...

@connormeredith sorry that this has slipped off our plate for so long. But it still sounds like an interesting path to follow. Do you have the bandwidth to resume working...

Oh boy this is embarrassing. @connormeredith I'm ready to merge this. Can you take care of the merge conflict? That file needs to be removed, since types are no longer...

> @gnapse, since jest-dom is scoped to DOM elements toHaveAttribute does work for quite a bit. Yes, the drawback is that in addition to tests being too verbose, people would...

That's something, yeah. I wonder if `dom-testing-library`'s `getByLabelText` gives you the dialog. Another possibility is to test, for instance, that you're not applying `onClick` handlers to elements that are not...

I do not think we've ever supported or needed to support having them consumed/imported individually. Bundling them all together in `matchers.js` is enough.

Hi thanks for taking the time to report this. > Under the hood antd doesn't detach the popconfirm and hidden it using display: none. I don’t see that that DOM...