gmriggs

"Those spell lines are a little wonky, as their spell.Power exceeds their item casters ItemSpellcrafts, so that probably needs to be accounted for, also." i think we saw issues with...

Hmm, maybe that section should be changed to this: ``` if (magicSkill > 0 && magicSkill >= (int)difficulty - 50) { var chance = 1.0f - SkillCheck.GetMagicSkillChance((int)magicSkill, (int)difficulty); var rng...

👍 to the idea for sure! Maybe someone can ping @FlaggAC about this as well... he brought up a discussion a few weeks ago about integrating the rcon protocol

You can cast self-debuffs if you had learned them, however NPKs could most certainly not debuff other NPKs in retail. That would be completely silly, and would effectively turn the...

> Should something similar be applied to the WorldDatabase where the weenies are read? Technically when a bunch of the of the weenie* tables are read in, it should be...

Update: With https://github.com/ACEmulator/ACE/pull/2809/commits/71c27feee83562330b667028ef1d16d0035cf405 , I am still able to repro the 'client repeatedly tries to log into world very rapidly' bug using a new set of repro steps: - Start...

With the revised implementation in https://github.com/ACEmulator/ACE/pull/2809/commits/593cc5f06a1e63a9062e6f256b3234d8da01b146, the previous bug is fixed

These should be handled by automated tests imo

Possible technologies / libraries mentioned: **System.Reactive / ReactiveUI** - http://reactivex.io/ (gmriggs, initial investigation seemed like Dictionary support w/ updates was not an exact fit) **LINQ expressions** - https://msdn.microsoft.com/en-us/library/system.linq.expressions.expression(v=vs.110).aspx, https://jacksondunstan.com/articles/3199 (fartwhif,...