Gabriel Simmer
Gabriel Simmer
I appreciate the points :) I'll work on addressing them. I do want to split out the logic a bit to simplify. Thanks!
For what it's worth I've deployed this patch to https://floofy.tech for testing and will report back soon.
@FireMasterK Given that sort of variable isn't sensitive, I don't image many people would use an environment variable to set it. *However*, we could swap out a single underscore for...
@FireMasterK Could I get a review on this?
Rebased onto master, should be all good now?
Worth noting that [the secrets operator already has this](https://github.com/Infisical/infisical/blob/main/helm-charts/secrets-operator/templates/deployment.yaml#L49-L52).
@pushcx Can do tomorrow! Will make a note of this. Haven't had a chance until recently to get back to this PR.
Rebased onto master with new active storage config.
Technically yes but not really sure what else needs doing.
> They load all of the page's data through websockets (json). Not quite sure where you got this from, as their own API docs[1] says you can just GET an...