Guillaume Masclet

icon indicating an email [email protected]

icon company @Linkurious icon location Paris, France icon location Backend lead at @Linkurious

Results 3 comments of Guillaume Masclet

fix(mssql): return no result when limit is zero

Thanks for your review :) sadly, fixing the test is not straigthforward, as the generated SQL query is considered as invalid by MS SQL Server. See details in the description...

[bug] Files may get reordered by the rotation job

Hi @iccicci, Thanks for your responsiveness :slightly_smiling_face: I think that checking `mtime` rather than `ctime` is a clear improvement: looks like there are too many things that can affect `ctime`....

[bug] Files may get reordered by the rotation job

Thanks a lot @iccicci! The `mtime` fix clearly mitigates the issue, so we're going to bump to `v3.2.5` to benefit from it. --- > When [options.maxFiles](https://github.com/iccicci/rotating-file-stream?tab=readme-ov-file#maxfiles) or [options.maxSize](https://github.com/iccicci/rotating-file-stream?tab=readme-ov-file#maxsize) are enabled...