Graham MacDonald

I forgot to add that making these two classes immutable seems to give no real benefit, so making them mutable to make the API less surprising should be a good...

Addressing your points, I would say that It's only clear if you've read the API code/docs fairly carefully that it's immutable - reading code that uses the API gives no...

In a language where immutable objects are the norm, then I'd agree. In Java, the norm is to have mutable objects. If the class is to be immutable, then any...

Ok, so people here are big on immutability ;-) I've committed versions of PixelFormat and ContextAttribs that are both fully immutable, and now use builders. The downside is that it's...

Dropping -u fails faster: ``` go: github.com/u-root/u-root master => v1.0.1-0.20201001202801-7709c8272b97 go get: inconsistent versions: github.com/u-root/[email protected] from github.com/u-root/u-root@master requires github.com/u-root/[email protected]+incompatible (not github.com/u-root/[email protected] from github.com/u-root/u-root@master) ```

I'm no go modules expert, but I suspect the dependency on iscinl might be causing problems, since it also refers to a specific older version of u-root. (The same version...

Any thoughts as to the solution? I'm afraid I don't have any good suggestions, but it does seem to block me from being able to use u-root via go modules...

Hi - were you able to try removing the go-module-incompatible release tags?

If this still results in a 10x improvement, would be worth revisiting it and merging it in.

We should look at merging this in. There are some conflicts due to more recent PRs being merged in first.