Greg MacWilliam

Results 21 issues of Greg MacWilliam

First off – thanks, and great work on the Ender suite. This is a slick jQuery alternative. I have noticed something I would consider an issue with Bonzo's implementation of...

When defining attributes, it would be extremely useful if supporting descriptions could also be specified. These supporting descriptions would be included in the web UI with each attribute input field,...

Bramble's present implementation of the `@boundary` directive has several indirections, and could be greatly streamlined. Myself and @exterm are considering some uses and would be interested in pursing some refactors...

2.0 release

Per https://github.com/movio/bramble/pull/108#issuecomment-969276181, it'd be nice to improve some logistics around how federation objects are mapped and then looked up. Some specific areas of improvement would be: - Properly lookup namespace...

@nmaquet something for the v2 roadmap: I think the strategy of hiding boundary queries from the gateway schema is a good default, however it thwarts dog-fooding when there’s a query...

enhancement

Stitching does not currently allow for multiple key formats distributed across services, for example: - **Catalog:** `Product @key(selectionSet: "{ upc }") ... @merge(keyField: "upc")` - **Vendor:** `Product @key(selectionSet: "{ id...

I noticed a `v3` milestone, so thought this would be a good time to submit a fix for several bugs in the complexity algorithm that have the potential to increase...

**Describe the bug** At present, the GraphQL Ruby language parser does not handle inline string literals according to spec, because it permits `\u0004` (newlines) within single-quoted strings. This is a...

**Describe the bug** [FieldsWillMerge.find_conflict](https://github.com/rmosolgo/graphql-ruby/blob/master/lib/graphql/static_validation/rules/fields_will_merge.rb#L213-L247) omits the [type parity check](https://github.com/graphql/graphql-js/blob/main/src/validation/rules/OverlappingFieldsCanBeMergedRule.ts#L620-L631) implemented by `graphql-js`. This deviates the GraphQL Ruby implementation from spec compliance. Unfortunately, fixing this issue is a breaking change because...

**Describe the bug** The `fields_have_appropriate_selections` validation presently allows the following selection: ```graphql query { myUnion } ``` With `myUnion` being a union type, this query returns the following payload: ```json...