Giuseppe
Giuseppe
Cc @johscheuer
The error seems to be, while building a Docker image: ``` #23 ERROR: "/YCSB" not found: not found ``` Unrelated?
Please hold merging this PR, I have found an unrelated issue in `main` (cannot call `Close()` because destruction happens already via finalizer) and I am looking into it.
I have verified that calling `fdb_database_destroy` multiple times eventually crashes with a `SIGSEGV`, so what is written in the [C API documentation](https://apple.github.io/foundationdb/api-c.html#c.fdb_database_destroy) is correct: > It must be called exactly...
Created PR here: https://github.com/apple/foundationdb/pull/11394
@johscheuer what do you think about starting to add a test suite for the Go binding? (in separate PRs)
> There are tests, those are located here: https://github.com/apple/foundationdb/blob/main/bindings/go/src/fdb/fdb_test.go. Those tests require a running FDB cluster. Thanks! Is there any area which needs more coverage? > I'm trying to understand...
> I think it's fine (until we have some benchmark tests in the bindings, which sounds like a good idea). Like I said I was mostly curious about the motivation...
I have added another commit for the second approach, destroying the transaction explicitly without relying on on GC. NOTE: the finalizer is passed as `transaction.destroy` instead of `(*transaction).destroy`, I think...
@johscheuer anything else to change here?